Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3 add precip cells for one timestep #40

Merged
merged 4 commits into from
Jan 11, 2018
Merged

Conversation

lindsayplatt
Copy link

@lindsayplatt lindsayplatt commented Jan 9, 2018

You can still hover over counties below the precip cells. Not sure if this is weird behavior or not, but I can easily turn it off by setting "pointer-events". Only doing one timestep right now. Animations through time is the next hurdle :)

state_map_hovers

This requires vizlab v0.2.2.9008 a la USGS-VIZLAB/vizlab#326

@lindsayplatt
Copy link
Author

I did notice that adding those precip cells make this noticeably slower, so we will definitely need to discuss where to draw the line between R and D3.

@aappling-usgs
Copy link
Member

What becomes slower - the page load, the interaction after loading, or both?

@lindsayplatt
Copy link
Author

I think it's the loading? You can see the map popup with everything, but there is a lag for when your mouse interactions start.

@jordansread
Copy link

but once that is up and running, no drag or lag in the mouseovers?

@lindsayplatt
Copy link
Author

lindsayplatt commented Jan 10, 2018

state_map_hovers

There's a little bit of a lag when you first try, then it looks slightly lagged when you go super super fast

@lindsayplatt
Copy link
Author

Thanks to some help from @mwernimont, css is now working and implemented. When this PR is merged, it will fix #38

@aappling-usgs
Copy link
Member

I bet we can improve the load time by packaging the data more concisely. After the polygons are all in place, I'm skeptical that D3 vs R have much control - we might even need to move away from SVG if we need still more speed. Overall, feeling optimistic about D3 and looking forward to experimenting for performance.

@lindsayplatt
Copy link
Author

@aappling-usgs I'm interested in getting some more hands on this branch to play around with how the data is formatted and passed through the process. I'm going to merge this for now, so we can keep moving along before Tech Tues.

@lindsayplatt lindsayplatt merged commit 4e57e52 into USGS-VIZLAB:d3 Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants