Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and clean up layout files #3

Open
aappling-usgs opened this issue Oct 2, 2017 · 0 comments
Open

Add and clean up layout files #3

aappling-usgs opened this issue Oct 2, 2017 · 0 comments

Comments

@aappling-usgs
Copy link
Member

Copying over https://github.com/USGS-VIZLAB/hurricane-maria/tree/master/layout is probably a good start. Also:

  • look through the classes for opportunities to switch to more obvious, informative names (e.g., .treasure-mark and .gage-blocker in hurricane-svg.css may not be as clear to the next team as they were to the maria group). Propagate changes into the visualization scripts as needed.
  • make sure elements are organized/grouped by the type of function they serve, and
  • add comments where they would help future vizmeisters understand or locate the right element quickly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant