Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add d3-scale-chromatic library #326

Merged
merged 3 commits into from
Jan 10, 2018

Conversation

lindsayplatt
Copy link

No description provided.

@lindsayplatt
Copy link
Author

I believe this failed build might be a network thing because of sciencebase:

  ── 2. Failure: sciencebase works (@tests-timestamps.R#118)  ────────────────────
  `ts1` not equal to as.POSIXct("2016-06-12 15:50:15", tz = "UTC").
  Modes: logical, numeric
  Attributes: < target is NULL, current is list >
  target is logical, current is POSIXct
  
  ══ testthat results  ═══════════════════════════════════════════════════════════
  OK: 128 SKIPPED: 2 FAILED: 2
  1. Failure: sciencebase works (@tests-timestamps.R#115) 
  2. Failure: sciencebase works (@tests-timestamps.R#118) 

@lindsayplatt
Copy link
Author

The network has been kind of weird this afternoon. I'm going to try again in the morning.

@ldecicco-USGS
Copy link
Contributor

I think this has been a thorn in our side for awhile

@lindsayplatt
Copy link
Author

That exact error for sciencebase?

@ldecicco-USGS
Copy link
Contributor

It sure sounds like something @aappling-usgs and I were struggling with this summer (?)....maybe she can remember off-hand

@lindsayplatt
Copy link
Author

Closing then re-opening to kick off again. I am getting some failures locally but they are different and seem like an issue with how messages are printed locally. See the "alwaysCurrent doesn't get rebuilt unless missing" test.

I'm going to document that here (when I run just vizmake('mayfly_nymph'), I do see [ BUILD ] data/mayfly_nymph.csv in the output):

suppressWarnings(expect_message(vizmake('mayfly_nymph'), '[ BUILD ] data/mayfly_nymph.csv', fixed=TRUE))
Error: `messages` does not match "[ BUILD ] data/mayfly_nymph.csv".
Actual values:
* [ \033[38;5;226m LOAD\033[39m ] \n
* (       ) vizlab/remake/timestamps/cuyahoga.txt\n
* (       ) vizlab/remake/timestamps/never_current.txt\n
* Starting build at 2018-01-10 08:59:49\n
* [ \033[38;5;226m READ\033[39m ]                                                |  \033[38;5;246m# loading sources\033[39m\n
* < \033[38;5;45m MAKE\033[39m > mayfly_nymph\n
* [ \033[38;5;67mBUILD\033[39m ] arguments_all                                  |  \033[38;5;246marguments_all <- collectItemArgume...\033[39m\n
* [ \033[38;5;226m READ\033[39m ]                                                |  \033[38;5;246m# loading packages\033[39m\n
* [ \033[38;5;67mBUILD\033[39m ] arguments_mayfly_nymph                         |  \033[38;5;246marguments_mayfly_nymph <- getEleme...\033[39m\n
* [ \033[38;5;67mBUILD\033[39m ] vizlab/remake/scripts/mayfly_nymph.R           |  \033[38;5;246mprepSources(outfile = "vizlab/rema...\03

I think it's just because extra characters are added locally. I'm 🤞 that this doesn't happen on Travis.

@lindsayplatt
Copy link
Author

So a restart didn't work ...

@aappling-usgs
Copy link
Member

I get the same set of test errors locally regardless of whether i'm running this branch or master. let's merge this PR and lean on a new vizlab issue (#327) to address the warnings and errors.

@aappling-usgs aappling-usgs merged commit 67bad6c into USGS-VIZLAB:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants