Axis par args not getting into the render #459
Conversation
|
Changes Unknown when pulling 14d4dd8 on jread-usgs:axis_trouble into ** on USGS-R:master**. |
R/axis.R
Outdated
| user_args[[fun.name]]$n.minor <- n.minor | ||
| user_args[[fun.name]]$tcl.minor <- tcl.minor | ||
| if (length(args$extracted.args) > 0){ | ||
| warning('axs.gsplot is not configured to support embedded function calls', call. = FALSE) |
There was a problem hiding this comment.
warning message should say "axis" not "axs"
| user.args[[fun.name]]$n.minor <- n.minor | ||
| user.args[[fun.name]]$tcl.minor <- tcl.minor | ||
|
|
||
| user.args[[fun.name]] <- append_replace(user.args[[fun.name]], args$option.args) |
There was a problem hiding this comment.
correct me if I'm wrong, but this is the legitimate change for this PR, right? The others are adding warnings, catching nulls, and changing code style/object names, but this line is what has been actually added
There was a problem hiding this comment.
yes, this is the meat of it
| gs <- points(gsplot(), 1, 0) %>% axis(side=1, tcl.minor = -0.136) | ||
| expect_equal(gs$side.1$axis[["tcl.minor"]], -0.136) | ||
| }) | ||
|
|
There was a problem hiding this comment.
should we add a test that does something with axis style args in other places? gs <- points(gsplot(), 1, 0, tcl=-0.4) %>% axis(side=1, n.minor = 4)
There was a problem hiding this comment.
@lindsaycarr added things per your review
There was a problem hiding this comment.
yep, waiting for travis to finish and then I will merge!
|
Changes Unknown when pulling ef206d1 on jread-usgs:axis_trouble into ** on USGS-R:master**. |
tcl and others were being ignored in
axis. This is aimed at fixing #456