-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config branch... #402
Config branch... #402
Changes from all commits
172875f
05e8d9f
6b7fe06
95278a8
7ce878c
a473d8c
caa3abd
a71d121
754800d
c287996
272cede
bbfc10f
51123dd
20c9a11
cde8a6a
a2cb09b
e2a29c1
c74b2a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,10 +85,10 @@ draw_legend <- function(gsplot) { | |
|
||
for (legend.name in names(gsplot[['legend']])) { | ||
|
||
par(xpd=TRUE) | ||
|
||
legend <- gsplot[['legend']][[legend.name]] | ||
if (legend$draw) { | ||
par(xpd=TRUE) | ||
|
||
legend <- appendLegendColumnInfo(legend) | ||
legend <- appendLegendPositionConfiguration(legend) | ||
# set required legend argument to NA if not exists | ||
|
@@ -99,8 +99,11 @@ draw_legend <- function(gsplot) { | |
#set bg so that fill/border/etc args are correct, then evaluate any quoted list items | ||
if (any(names(legend) %in% c("bg"))) { | ||
par(bg=legend$bg) | ||
} else { | ||
par(bg = ifelse(par('bg') == "transparent", "#FFFFFF", par('bg'))) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we still need this - it evaluates anything in legend that we set with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agreed, I think that's a pasting error on my part, I certainly never planned to delete that line. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 I really did not know that "transparent" was an option! |
||
} | ||
legend <- lapply(legend, function(x) {unname(sapply(x, function(x) {eval(x)}))}) | ||
|
||
# clean out arguments not allowed by legend | ||
legend <- legend[na.omit(match(names(default.args), names(legend)))] | ||
legend(legend) | ||
|
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,6 @@ lines: | |
col: "black" | ||
lty: 1 | ||
lwd: 1 | ||
labels: FALSE | ||
abline: | ||
col: "grey" | ||
lty: 1 | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was thinking that default would be
custom.config = NULL
since that is what you would get ifcustom.config = object[["global"]][["config"]][["config.file"]]
didn't exist. Maybe I missed it, but where do you test for!custom.config
or where is that used?