Formulas should be allowed

[ldecicco-USGS]

plot(-3:3,-3:3)
points(y~x)

library(gsplot)
gs <- gsplot() %>%
  points(y~x)
gs

[jordansread]

see #151

[ldecicco-USGS]

I think this is going to be a little trickier...not 100% sure. Have to make sure plot calls plot.formula appropriately. Also, plot.factor? plot.ts? plot.data.frame? plot.function?

[jordansread]

I linked in the wrong issue for that last comment. I have not worked on this issue. Agree that it will be tricky.

[jordansread]

I think we need something like this when we look up the function, and then failover to .default:

getS3method('points',class(object), optional=TRUE)

which works for class(object) == 'formula'

[jordansread]

• support for base plot override (i.e., what LDC has above breaks when gsplot is loaded
• support for using formulas in gsplot workflow (the second example from LDC)

[jordansread]

see #159 which takes care of the first thing.

[jordansread]

Is this still open?

What is the criteria for closing?

this works

gs <- gsplot() %>%
    points(y~x, data=list(x=-3:3,y=-3:3))
gs

what other patterns do we have? ones that look to the parent.frame for x and y as well?

[ldecicco-USGS]

I didn't check, but does it work for lines too? That was the one thing I was going to check before closing.

[jordansread]

yep, it does