SYS-1637: Remove master file URLs from OAI feed #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements SYS-1637. Bumps version to
v1.1.11
for deployment.This PR fixes a bug which allowed URLs for master files to be included in the OAI feed. These files are accessible only via the staff UI, so including URLs for them is not appropriate for OAI content or the public site.
The fix makes relevant methods in the
OralHistoryMods
class more specific, so only file URLs for submasters are included in the OAI feed's MODs records. A new test is added which confirms master file URLs are not included.Testing
Confirm all 112 tests pass. No need for more specific testing.
Locally, I grabbed before and after versions of 2 records and compared them: