Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LaunchArgs are ignored during AutoRulesCheck #117

Closed
RudolfSchreier opened this issue Apr 22, 2024 · 0 comments · Fixed by #118
Closed

LaunchArgs are ignored during AutoRulesCheck #117

RudolfSchreier opened this issue Apr 22, 2024 · 0 comments · Fixed by #118
Labels
bug Something isn't working Fixed/Completed Commits related to this are in master, if the issue is still open, it's yet to be released
Milestone
v0.9

Comments

@RudolfSchreier
Copy link
Contributor

In AutoRulesCheck.cs, the LaunchArgs are checked for being empty or null.

However, if they are not null or empty, they are then not used.

This results in the configured LaunchArgs not being handed to the browser.
I am trying to use this to launch specific links in specific Firefox profiles (using -p <profilename> as LaunchArgs) and this is a blocking issue.
@U-C-S U-C-S added the bug Something isn't working label Apr 22, 2024
@ItsJustRuby ItsJustRuby mentioned this issue Apr 22, 2024
Merged
@U-C-S U-C-S added this to the v0.9 milestone May 16, 2024
@U-C-S U-C-S mentioned this issue Jul 12, 2024
Closed
@U-C-S U-C-S added the Fixed/Completed Commits related to this are in master, if the issue is still open, it's yet to be released label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Fixed/Completed Commits related to this are in master, if the issue is still open, it's yet to be released
Projects
None yet
Milestone
v0.9
Development

Successfully merging a pull request may close this issue.

fix: No longer ignore LaunchArgs in AutoRulesCheck
2 participants
@U-C-S @RudolfSchreier