-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn’t always work on iOS safari #28
Comments
Interesting. I think I may see this bug as well in my testing. I'll look more into it and keep this issue updated. |
I forgot to mention, that in most cases, when clicking the little floppy disk icon, it just gets stuck in a loop. Nothing really happens. Maybe that could be of some help? Also, I’m not sure of this, but it could be that the docker container is being throttled for some odd reason. Not sure if it’s just me, but I think it’s a bit too slow compared to anything else being run on that same VPS (it’s the only docker container I have, everything else runs directly on the VPS). I tried running youtubedl-material on the VPS directly (To see if the issue still persists), but npm install gave the following error (probably has something to do with me being on centos 7 rather than ubuntu, in that case ubuntu doesn’t seem to work on my host for some weird reason):
And here’s the log:
It just seems to be a bunch of issues flooding in all at once, apologies if this is overwhelming. |
The more info the merrier :)
Just realized this isn't possible in iOS. Oops! Is it an iOS-only problem or does it not work on desktop as well?
From a first glance it doesn't look like an OS issue, it looks like an NPM issue (I may be wrong). Apparently someone else had a similar error, and what fixed it for them is updating npm, and then cleaning the npm cache. To do this, run these commands:
Let me know if this fixes the npm error for you. |
It only happens in iOS, nowhere else at all. Also, If i use a download manager app on iOS, it works fine. Only in safari does it simply not work (Well, it works sometimes) even though safari does have a download manager as of iOS 13. Trying to update npm gets me a similar error as well:
The log being:
Seems like npm is really messed up |
Update on this issue: I noticed the following behavior after doing some digging in: When i try to download the video/audio through youtubedl-material on iOS, it (like it should) takes me to the screen with the video preview and floppy disk save icon. Now I previously mentioned that clicking the floppy disk icon would cause it to spin on a loop without any download prompt showing up. HOWEVER, it seems like when that happens, it’s actually downloading the video in the background (no prompt or status bar or anything) and only after waiting forever do i get the download prompt, which when clicked makes the video download instantly (proving that it has already been downloaded in the background while waiting for the download prompt) Not sure how well I described this (pretty sure i did a terrible job at that). Furthermore, when using a download manager app on iOS, i get the download prompt as soon as the preview page loads up without having to click anywhere. However, the video/audio downloads with the title “Youtube Downloader.mp3” rather than the title of the video/song. And it’s metadata doesn’t contain the title of the video/song either. So it seems to be two issues at once that might possibly be related. This is all on the latest version (4.1) |
Update: It now works perfectly fine… not sure if you’ve fixed it or it (somehow) managed to resolve itself, but all seems to work perfectly now! |
Interesting! No, nothing was changed, I assume Apple just updated iOS so it plays more nicely with downloads. I did test this several times using BrowserStack (thankfully it's free for open-source projects), but all I could find was extremely inconsistent behavior -- sometimes it worked, sometimes it didn't. Some of my family members have iPhones and I think I saw the same thing there. I'll close the issue, but if it comes up again, feel free to drop a comment and I'll open this up again. |
Hello,
When using this on safari on iOS, I don’t always get the download prompt. In most cases, it just plays the video with absolutely no prompt to download at all!
The text was updated successfully, but these errors were encountered: