Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache doesn't take modified dependencies into account #672

Closed
mihe opened this issue Aug 24, 2018 · 3 comments
Closed

Cache doesn't take modified dependencies into account #672

mihe opened this issue Aug 24, 2018 · 3 comments
Labels

Comments

@mihe
Copy link

mihe commented Aug 24, 2018

Not sure if this is by design or not, but it seems the caching doesn't take modifications of the code you're importing into account at all when calculating the hash.

I just had a problem where my Mocha tests (that are written in TypeScript, using -r ts-node/register) were still running just fine despite the fact that I'd changed the signature of the functions I was importing and testing.

With the cache disabled I got the compilation errors I was expecting.

If this is the intended behavior I would consider it somewhat dangerous to have the cache enabled by default.

@blakeembrey
Copy link
Member

@mihe This is a very good point. I'll think about how this may be solved, and if I come up with nothing, disable/remove in the next release.

@crysislinux
Copy link

I am not sure if I hit the same problem.

My project can run with --no-cache, but not without it.

@webuniverseio
Copy link

Not sure in which version this got fixed, but I had trouble with 9.1.1 release, I end up using --prefer-ts-exts=true which is skipping js cache and using ts files instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants