Rename file module: file move

[basarat]

• rename file module (this is a big pain and the reason why we added ///ts:import transform in the first place)

[ifeltsweet]

Completely agree. Is this in the plans?

[basarat]

Completely agree. Is this in the plans?

We already have the refactoring code working (

atom-typescript/lib/main/atom/commands/commands.ts

Lines 181 to 213 in ac11fe7

	let relativePath = editor.getTextInRange(editor.bufferRangeForScopeAtCursor(matched)).replace(/['"]+/g, '');
	if (!utils.pathIsRelative(relativePath)) {
	atom.notifications.addInfo('AtomTS: Can only rename external modules if they are relative files!');
	return;
	}
	let completePath = path.resolve(path.dirname(atomUtils.getCurrentPath()), relativePath) + '.ts';
	// TODO: Actually rename the file
	renameView.panelView.renameThis({
	autoSelect: false,
	title: 'Rename File',
	text: completePath,
	openFiles: [],
	closedFiles: [],
	onCancel: () => { },
	onValidate: (newText): string => {
	if (!newText.trim()) {
	return 'If you want to abort : Press esc to exit'
	}
	return '';
	},
	onCommit: (newText) => {
	newText = newText.trim();
	parent.getRenameFilesRefactorings({ oldPath: completePath, newPath: newText })
	.then((res) => {
	applyRefactorings(res.refactorings);
	});
	}
	});
	atom.notifications.addInfo('AtomTS: File rename comming soon!');

) i.e. all paths in the code are updated on renaming. Pending :

• the file is not actually renamed on file system
• the user can't trigger the refactoring from the tree view Provide a service API atom/tree-view#433

[trusktr]

This would be sweet. Can we keep this open?

[lierdakil]

Please open a new issue lest I miss this in the backlog.