Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Media enclosed css #41

Closed
jamesthecat7 opened this issue Aug 10, 2014 · 4 comments
Closed

@Media enclosed css #41

jamesthecat7 opened this issue Aug 10, 2014 · 4 comments

Comments

@jamesthecat7
Copy link

Parser is unable to deal with css enclosed within @media element. Example here: http://www.google.com/about/default.css

Google use '@media screen,projection{' to encapsulate all remaining css. This causes EXCSS to throw NotSupportedExceptions from the methods 'AddSeparator' and 'AddTerm' in TermList.cs

Is it possible to make it handle this by telling it to close curley braces before the next element?

@TylerBrinks
Copy link
Owner

I'd be happy to take a pull request for this.

@Piedone
Copy link

Piedone commented Sep 5, 2014

Does this mean ExCSS isn't being able to deal with @media queries at all?

@TylerBrinks
Copy link
Owner

The engine may need to be updated to understand the slight difference in rule set inside a media query. It's something I'd like to add for sure.

@TylerBrinks
Copy link
Owner

I'm not able to reproduce this - the current unit tests are passing media element parsing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants