Setting staleWhileRevalidate in the configuration does not actually set stale-while-revalidate

[flavianh]

Issue Summary

In order to leverage Cloudflare edge cache for a request to / and avoid overloading my server with requests, I would like to set some level of staleness to my cache (in the absence of Last Modified of E-tag headers on ghost's part).

Steps to Reproduce

1. Set this configuration

...
"caching": {
    "frontend": {
      "maxAge": 86400,
      "staleWhileRevalidate": 300
    }
}

2. Notice that maxAge changes when requesting index.html but stale-while-revalidate is not set.

This is unexpected as staleWhileRevalidate is listed as an option in the cache middleware:

Ghost/ghost/mw-cache-control/lib/mw-cache-control.js

Line 15 in 9dd48f9

* @param {number} [options.staleWhileRevalidate] The stale-while-revalidate in seconds to use when profile is "public"

Ghost Version

5.108.2

Node.js Version

20.18.2

How did you install Ghost?

Ubuntu 20.04.6 LTS

Database type

MySQL 8

Browser & OS version

No response

Relevant log / error output

Code of Conduct

• I agree to be friendly and polite to people in this repository

[mike182uk]

Thanks for reporting this @flavianh

This looks to be a bug with the staleWhileRevalidate option does not actually get used in the frontend caching middleware, which is why you are not seeing the header get set