Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Move Jest to parent package (devDependencies) #722

Closed
ferrannp opened this issue Mar 6, 2017 · 2 comments
Closed

Move Jest to parent package (devDependencies) #722

ferrannp opened this issue Mar 6, 2017 · 2 comments

Comments

@ferrannp
Copy link
Contributor

ferrannp commented Mar 6, 2017

The same we did here with eslint and flow #719 can be done with jest. So we install it only once.

The blocker here is that we need to convert gluestick-shared tests to Jest (there are very few so it should be fast).

This should also allow us to move presets and plugins needed for test env so the problem of running test from parent package should also be solved.

@ferrannp
Copy link
Contributor Author

ferrannp commented Mar 8, 2017

This will also solve issue of publishing coverage to npm since that folder will be created into parent directory. Therefore, we do not need to add coverage in every .npmignore once this issue is resolved.

@ferrannp
Copy link
Contributor Author

ferrannp commented Mar 9, 2017

This might need some more thinking, see jestjs/jest#3112.

It also needs a solution since running tests form parent package (using lerna) does not really work locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants