Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt, enable import grouping #7598

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

piotrp
Copy link
Member

@piotrp piotrp commented Feb 26, 2025

Describe your changes

Four commits:

  1. Renamed the pl.touk.nussknacker.engine.sttp package, because wildcard import of pl.touk.nussknacker.engine made all following sttp imports invalid due to name clash (our package was chosen over project dependency)
  2. Removal of scalafix
  3. Update of scalafmt
  4. sbt 'scalafmtAll; scalafmtSbt'

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

piotrp added a commit that referenced this pull request Feb 26, 2025
…touk.nussknacker.http.backend (#7598)

They were breaking sttp imports when import list contained 'import pl.touk.nussknacker.engine._'
piotrp added a commit that referenced this pull request Feb 26, 2025
piotrp added a commit that referenced this pull request Feb 26, 2025
@piotrp piotrp force-pushed the scalafmt-import-order branch from ad90542 to 300a449 Compare February 26, 2025 22:20
piotrp added a commit that referenced this pull request Feb 26, 2025
@github-actions github-actions bot added the docs label Feb 26, 2025
…touk.nussknacker.http.backend (#7598)

They were breaking sttp imports when import list contained 'import pl.touk.nussknacker.engine._'
@piotrp piotrp force-pushed the scalafmt-import-order branch from 300a449 to 24b1f9d Compare February 26, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant