-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-7142] Lift TypingResult information for dictionaries #7145
Merged
DeamonDev
merged 1 commit into
staging
from
NU-7142-add-lift-typing-for-dictionaries-v2
Nov 14, 2024
Merged
[NU-7142] Lift TypingResult information for dictionaries #7145
DeamonDev
merged 1 commit into
staging
from
NU-7142-add-lift-typing-for-dictionaries-v2
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f29be60
to
69c234b
Compare
arkadius
reviewed
Nov 13, 2024
...ala/pl/touk/nussknacker/engine/language/dictWithLabel/DictKeyWithLabelExpressionParser.scala
Show resolved
Hide resolved
78a512b
to
10ee2df
Compare
10cd2c6
to
7666797
Compare
7666797
to
f14d5df
Compare
arkadius
approved these changes
Nov 14, 2024
lciolecki
pushed a commit
that referenced
this pull request
Nov 27, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki
pushed a commit
that referenced
this pull request
Nov 29, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki
pushed a commit
that referenced
this pull request
Dec 3, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki
pushed a commit
that referenced
this pull request
Dec 4, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki
pushed a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki
pushed a commit
that referenced
this pull request
Dec 10, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Since
TypedClass
does not have information about passed valuevalueOpt = None :: Option[Any]
I propose to lift thisTypingResult
intoTypedObjectWithValue
at the stage of passing downTypingResult
toDictKeyWithLabelExpression
. The fact of thisvalueOpt
beingNone
leads to the validation problem whenCompileTimeEvaluableValueValidator
is being used forDictKeyWithLabelExpression
's.For more context, see linked issue to this PR.
Checklist before merge