Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-7142] Lift TypingResult information for dictionaries #7145

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

DeamonDev
Copy link
Contributor

@DeamonDev DeamonDev commented Nov 13, 2024

Describe your changes

Since TypedClass does not have information about passed value valueOpt = None :: Option[Any] I propose to lift this TypingResult into TypedObjectWithValue at the stage of passing down TypingResult to DictKeyWithLabelExpression. The fact of this valueOpt being None leads to the validation problem when CompileTimeEvaluableValueValidator is being used for DictKeyWithLabelExpression's.

For more context, see linked issue to this PR.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@DeamonDev DeamonDev force-pushed the NU-7142-add-lift-typing-for-dictionaries-v2 branch 2 times, most recently from f29be60 to 69c234b Compare November 13, 2024 12:36
@DeamonDev DeamonDev self-assigned this Nov 13, 2024
@DeamonDev DeamonDev changed the title [NU-7142] Lift TypingResult for dictionaries V2 [NU-7142] Lift TypingResult information for dictionaries Nov 13, 2024
@DeamonDev DeamonDev marked this pull request as ready for review November 13, 2024 13:45
@DeamonDev DeamonDev force-pushed the NU-7142-add-lift-typing-for-dictionaries-v2 branch 3 times, most recently from 78a512b to 10ee2df Compare November 14, 2024 09:57
@github-actions github-actions bot added the docs label Nov 14, 2024
@DeamonDev DeamonDev force-pushed the NU-7142-add-lift-typing-for-dictionaries-v2 branch 2 times, most recently from 10cd2c6 to 7666797 Compare November 14, 2024 10:29
@DeamonDev DeamonDev force-pushed the NU-7142-add-lift-typing-for-dictionaries-v2 branch from 7666797 to f14d5df Compare November 14, 2024 10:39
@DeamonDev DeamonDev requested a review from arkadius November 14, 2024 12:02
@DeamonDev DeamonDev merged commit 0356376 into staging Nov 14, 2024
18 checks passed
@DeamonDev DeamonDev deleted the NU-7142-add-lift-typing-for-dictionaries-v2 branch November 14, 2024 13:38
lciolecki pushed a commit that referenced this pull request Nov 27, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki pushed a commit that referenced this pull request Nov 29, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki pushed a commit that referenced this pull request Dec 3, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki pushed a commit that referenced this pull request Dec 4, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki pushed a commit that referenced this pull request Dec 6, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
lciolecki pushed a commit that referenced this pull request Dec 10, 2024
Co-authored-by: Piotr Rudnicki <prn@touk.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let DictKeyWithLabelExpressionTypingInfo's TypingResult to be aware of associated value
2 participants