Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario labels in metadata #6935

Merged
merged 14 commits into from
Sep 26, 2024
Merged

Scenario labels in metadata #6935

merged 14 commits into from
Sep 26, 2024

Conversation

mateuszkp96
Copy link
Contributor

@mateuszkp96 mateuszkp96 commented Sep 24, 2024 •
edited
Loading

Describe your changes

Scenario labels added to #meta variable

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

created: #6951
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@github-actions @mateuszkp96
Updated snapshots (#6936)
dc3b477 
Co-authored-by: mateuszkp96 <26696870+mateuszkp96@users.noreply.github.com>
@github-actions github-actions bot added client client main fe ui labels Sep 24, 2024
@github-actions github-actions bot added the docs label Sep 24, 2024
@mateuszkp96 mateuszkp96 changed the title [DRAFT] Scenario labels in metadata Scenario labels in metadata Sep 24, 2024
@mateuszkp96 mateuszkp96 requested a review from mslabek September 24, 2024 09:56
arkadius
arkadius reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM, two comments added

@github-actions github-actions bot mentioned this pull request Sep 26, 2024
Merged
@github-actions @mateuszkp96
Updated snapshots (#6951)
bab52f1 
Co-authored-by: mateuszkp96 <26696870+mateuszkp96@users.noreply.github.com>
@github-actions github-actions bot removed ui client client main fe labels Sep 26, 2024
@mateuszkp96 mateuszkp96 merged commit a2e3279 into staging Sep 26, 2024
18 of 21 checks passed
@mateuszkp96 mateuszkp96 deleted the scenario-labels-in-metadata branch September 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

@mslabek mslabek Awaiting requested review from mslabek

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszkp96 @arkadius