Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nu-1792] properties save fix when fragment is in different group than fragments #6725

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[Nu-1792] properties save fix when fragment is in different group than fragments #6725

merged 2 commits into from
Sep 3, 2024

Conversation

Dzuming
Copy link
Contributor

@Dzuming Dzuming commented Sep 2, 2024 •
edited
Loading

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Sep 2, 2024
@Dzuming Dzuming changed the base branch from staging to release/1.17 September 2, 2024 12:48
lciolecki
lciolecki approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@lciolecki lciolecki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast reaction!

@raphaelsolarski raphaelsolarski merged commit bb82d34 into release/1.17 Sep 3, 2024
13 checks passed
@raphaelsolarski raphaelsolarski deleted the NU-1792-properties-save-fix-when-fragment-is-in-different-group-than-fragments branch September 3, 2024 07:45
lciolecki pushed a commit that referenced this pull request Sep 3, 2024
@Dzuming @lciolecki
[Nu-1792] properties save fix when fragment is in different group tha…
4aeca14 
…n fragments (#6725)

* NU-1792 properties save fix when fragment is in a different group than fragments

* NU-1792 format message
Dzuming added a commit that referenced this pull request Sep 4, 2024
@Dzuming
[Nu-1792] properties save fix when fragment is in different group tha…
30c2fef 
…n fragments (#6725)

* NU-1792 properties save fix when fragment is in a different group than fragments

* NU-1792 format message

(cherry picked from commit bb82d34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lciolecki lciolecki lciolecki approved these changes

@raphaelsolarski raphaelsolarski raphaelsolarski approved these changes

@mslabek mslabek mslabek approved these changes

Assignees
No one assigned
Labels
client client main fe ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dzuming @lciolecki @raphaelsolarski @mslabek