Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysis feedback #4

Open
4 of 6 tasks
Chichisheep opened this issue Jul 24, 2020 · 2 comments
Open
4 of 6 tasks

analysis feedback #4

Chichisheep opened this issue Jul 24, 2020 · 2 comments

Comments

@Chichisheep
Copy link

Chichisheep commented Jul 24, 2020

  • First sentence "The Summed Parallel Infinite Impulse Response (SPIIR) pipeline, first implemented by Shaun Hooper" not very appropriate. The SPIIR method has been developed by a group of people and is still being improved. SPIIR "pipeline" employs the SPIIR method and other components. Shaun implemented the first version of SPIIR filtering in the pipeline. Many people contribute to this pipeline.

  • label all equations ? easier to refer to.

  • work explained first and then span ? easier to understand.

  • Sec. 3.2 number of filters F is number of templates

  • Sec. 3.3 O(ST/P) not clear what is T

  • you are right, the complexity for postcoh is ~ D^3 instead of D^4.

@Tommoa
Copy link
Owner

Tommoa commented Jul 27, 2020

Hi @Chichisheep, thanks for your feedback!

  • The first sentence was taken from my project proposal and was modified based on feedback on the proposal. Would a more appropriate phrasing be:

    The Summed Parallel Infinite Impulse Response (SPIIR) pipeline, based on the SPIIR method originally implemented by Shaun Hooper in 2012...

  • I'll move to using equation environments instead of \[\] so that equations are labelled
  • If you are referring to the background section, work is explained first because it is essentially asking the question of what the time complexity would be if everything was run sequentially. I believe most of the individual sections also discuss time complexities in that order, although I will run through and double check.
  • For some reason I originally had "Templates" there instead of "Filters" and changed it to filters because I had wanted to use T for one of the math variables even though templates is indeed the right word for it. I'll change it back.
  • T is the one remaining relic from the previous point, where it was templates

@Chichisheep
Copy link
Author

Chichisheep commented Aug 3, 2020

"If you are referring to the background section, work is explained first because it is essentially asking the question of what the time complexity would be if everything was run sequentially. I believe most of the individual sections also discuss time complexities in that order, although I will run through and double check."

The order in the main sections is currently span first then work. I would think that "work" first, followed by "span" explanation would be more logical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants