-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analysis feedback #4
Comments
Hi @Chichisheep, thanks for your feedback!
|
"If you are referring to the background section, work is explained first because it is essentially asking the question of what the time complexity would be if everything was run sequentially. I believe most of the individual sections also discuss time complexities in that order, although I will run through and double check." The order in the main sections is currently span first then work. I would think that "work" first, followed by "span" explanation would be more logical. |
First sentence "The Summed Parallel Infinite Impulse Response (SPIIR) pipeline, first implemented by Shaun Hooper" not very appropriate. The SPIIR method has been developed by a group of people and is still being improved. SPIIR "pipeline" employs the SPIIR method and other components. Shaun implemented the first version of SPIIR filtering in the pipeline. Many people contribute to this pipeline.
label all equations ? easier to refer to.
work explained first and then span ? easier to understand.
Sec. 3.2 number of filters F is number of templates
Sec. 3.3 O(ST/P) not clear what is T
you are right, the complexity for postcoh is ~ D^3 instead of D^4.
The text was updated successfully, but these errors were encountered: