This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
ConfigurationをNuxtConfigに変更する #4924
Merged
soutaito
merged 8 commits into
Tokyo-Metro-Gov:development
from
goki90210:feature/4923-configure-to-nuxtconfig
Jul 7, 2020
Merged
ConfigurationをNuxtConfigに変更する #4924
soutaito
merged 8 commits into
Tokyo-Metro-Gov:development
from
goki90210:feature/4923-configure-to-nuxtconfig
Jul 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ありがとうございます。 メリットとしては |
@goki90210 以下のようにすれば、 extend(config) { |
@munierujp |
…-configure-to-nuxtconfig
….com/goki90210/covid19 into feature/4923-configure-to-nuxtconfig
ご提案ありがとうございます!yarn.lockが激しくコンフリクトしますので、先に #4933 を採用する方向でいいでしょうか? |
@kaizumaki |
kaizumaki
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決する issue / Resolved Issues
📝 関連する issue / Related Issues
⛏ 変更内容 / Details of Changes
、Configuration as WebpackConfiguration を Configurationに変更する。import {Configuration as WebpackConfiguration} from 'webpack'
を削除し、これにともないwebpackを直接参照する箇所がなくなるため、packege.jsonのdevDependenciesからwebpackを削除する。
📸 スクリーンショット / Screenshots