From 91fc16959cb468ca5f38015282b871d29d85d4fb Mon Sep 17 00:00:00 2001 From: anubansal Date: Wed, 10 Jul 2019 15:41:25 +0530 Subject: [PATCH 01/41] added trackId to exoplayer onLoad callback --- .../java/com/brentvatne/exoplayer/ReactExoplayerView.java | 3 ++- .../java/com/brentvatne/exoplayer/VideoEventEmitter.java | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java index 655e4e286e..1826421374 100644 --- a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java +++ b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java @@ -549,8 +549,9 @@ private void videoLoaded() { Format videoFormat = player.getVideoFormat(); int width = videoFormat != null ? videoFormat.width : 0; int height = videoFormat != null ? videoFormat.height : 0; + int trackId = videoFormat != null ? videoFormat.id : -1; eventEmitter.load(player.getDuration(), player.getCurrentPosition(), width, height, - getAudioTrackInfo(), getTextTrackInfo(), getVideoTrackInfo()); + getAudioTrackInfo(), getTextTrackInfo(), getVideoTrackInfo(), trackId); } } diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java index 00f51c94cd..72381266bc 100644 --- a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java +++ b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java @@ -109,6 +109,7 @@ class VideoEventEmitter { private static final String EVENT_PROP_CURRENT_TIME = "currentTime"; private static final String EVENT_PROP_SEEK_TIME = "seekTime"; private static final String EVENT_PROP_NATURAL_SIZE = "naturalSize"; + private static final String EVENT_PROP_TRACK_ID = "trackId"; private static final String EVENT_PROP_WIDTH = "width"; private static final String EVENT_PROP_HEIGHT = "height"; private static final String EVENT_PROP_ORIENTATION = "orientation"; @@ -137,7 +138,7 @@ void loadStart() { } void load(double duration, double currentPosition, int videoWidth, int videoHeight, - WritableArray audioTracks, WritableArray textTracks, WritableArray videoTracks) { + WritableArray audioTracks, WritableArray textTracks, WritableArray videoTracks, int trackId) { WritableMap event = Arguments.createMap(); event.putDouble(EVENT_PROP_DURATION, duration / 1000D); event.putDouble(EVENT_PROP_CURRENT_TIME, currentPosition / 1000D); @@ -151,7 +152,7 @@ void load(double duration, double currentPosition, int videoWidth, int videoHeig naturalSize.putString(EVENT_PROP_ORIENTATION, "portrait"); } event.putMap(EVENT_PROP_NATURAL_SIZE, naturalSize); - + event.putInt(EVENT_PROP_TRACK_ID, trackId); event.putArray(EVENT_PROP_VIDEO_TRACKS, videoTracks); event.putArray(EVENT_PROP_AUDIO_TRACKS, audioTracks); event.putArray(EVENT_PROP_TEXT_TRACKS, textTracks); From e14221f05580e8ae0b629ee27b9d4a860b0c45ad Mon Sep 17 00:00:00 2001 From: anubansal Date: Wed, 10 Jul 2019 17:14:52 +0530 Subject: [PATCH 02/41] added trackInfo to bandwidth callback --- .../com/brentvatne/exoplayer/ReactExoplayerView.java | 12 ++++++++++-- .../com/brentvatne/exoplayer/VideoEventEmitter.java | 9 ++++++--- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java index 1826421374..3a33c46e52 100644 --- a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java +++ b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java @@ -253,7 +253,15 @@ public void cleanUpResources() { @Override public void onBandwidthSample(int elapsedMs, long bytes, long bitrate) { if (mReportBandwidth) { - eventEmitter.bandwidthReport(bitrate); + if (player === null) { + eventEmitter.bandwidthReport(bitrate, 0, 0, -1); + } else { + Format videoFormat = player.getVideoFormat(); + int width = videoFormat != null ? videoFormat.width : 0; + int height = videoFormat != null ? videoFormat.height : 0; + String trackId = videoFormat != null ? videoFormat.id : "-1"; + eventEmitter.bandwidthReport(bitrate, height, width, trackId); + } } } @@ -549,7 +557,7 @@ private void videoLoaded() { Format videoFormat = player.getVideoFormat(); int width = videoFormat != null ? videoFormat.width : 0; int height = videoFormat != null ? videoFormat.height : 0; - int trackId = videoFormat != null ? videoFormat.id : -1; + String trackId = videoFormat != null ? videoFormat.id : "-1"; eventEmitter.load(player.getDuration(), player.getCurrentPosition(), width, height, getAudioTrackInfo(), getTextTrackInfo(), getVideoTrackInfo(), trackId); } diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java index 72381266bc..533fdfd464 100644 --- a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java +++ b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java @@ -138,7 +138,7 @@ void loadStart() { } void load(double duration, double currentPosition, int videoWidth, int videoHeight, - WritableArray audioTracks, WritableArray textTracks, WritableArray videoTracks, int trackId) { + WritableArray audioTracks, WritableArray textTracks, WritableArray videoTracks, String trackId) { WritableMap event = Arguments.createMap(); event.putDouble(EVENT_PROP_DURATION, duration / 1000D); event.putDouble(EVENT_PROP_CURRENT_TIME, currentPosition / 1000D); @@ -152,7 +152,7 @@ void load(double duration, double currentPosition, int videoWidth, int videoHeig naturalSize.putString(EVENT_PROP_ORIENTATION, "portrait"); } event.putMap(EVENT_PROP_NATURAL_SIZE, naturalSize); - event.putInt(EVENT_PROP_TRACK_ID, trackId); + event.putString(EVENT_PROP_TRACK_ID, trackId); event.putArray(EVENT_PROP_VIDEO_TRACKS, videoTracks); event.putArray(EVENT_PROP_AUDIO_TRACKS, audioTracks); event.putArray(EVENT_PROP_TEXT_TRACKS, textTracks); @@ -177,9 +177,12 @@ void progressChanged(double currentPosition, double bufferedDuration, double see receiveEvent(EVENT_PROGRESS, event); } - void bandwidthReport(double bitRateEstimate) { + void bandwidthReport(double bitRateEstimate, int height, int width, String id) { WritableMap event = Arguments.createMap(); event.putDouble(EVENT_PROP_BITRATE, bitRateEstimate); + event.putInt(EVENT_PROP_WIDTH, width); + event.putInt(EVENT_PROP_HEIGHT, height); + event.putString(EVENT_PROP_TRACK_ID, id); receiveEvent(EVENT_BANDWIDTH, event); } From a102ce788b2f521f3c6facd1eb3749a0f7d2df74 Mon Sep 17 00:00:00 2001 From: anubansal Date: Wed, 10 Jul 2019 17:21:30 +0530 Subject: [PATCH 03/41] syntax fix --- .../main/java/com/brentvatne/exoplayer/ReactExoplayerView.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java index 3a33c46e52..d52e625ac7 100644 --- a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java +++ b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java @@ -253,7 +253,7 @@ public void cleanUpResources() { @Override public void onBandwidthSample(int elapsedMs, long bytes, long bitrate) { if (mReportBandwidth) { - if (player === null) { + if (player == null) { eventEmitter.bandwidthReport(bitrate, 0, 0, -1); } else { Format videoFormat = player.getVideoFormat(); From eb14d95e7c27a210e55c0364a19efdef6f9250de Mon Sep 17 00:00:00 2001 From: anubansal Date: Wed, 10 Jul 2019 17:27:59 +0530 Subject: [PATCH 04/41] syntax fix --- .../main/java/com/brentvatne/exoplayer/ReactExoplayerView.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java index d52e625ac7..e22581abd1 100644 --- a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java +++ b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java @@ -254,7 +254,7 @@ public void cleanUpResources() { public void onBandwidthSample(int elapsedMs, long bytes, long bitrate) { if (mReportBandwidth) { if (player == null) { - eventEmitter.bandwidthReport(bitrate, 0, 0, -1); + eventEmitter.bandwidthReport(bitrate, 0, 0, "-1"); } else { Format videoFormat = player.getVideoFormat(); int width = videoFormat != null ? videoFormat.width : 0; From 2ce2e34b4aeec89cab04045704351102f04132d5 Mon Sep 17 00:00:00 2001 From: anubansal Date: Tue, 3 Sep 2019 12:55:24 +0530 Subject: [PATCH 05/41] version update --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 8e5e3ddc06..2617e38d83 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-native-video", - "version": "4.3.1", + "version": "4.3.2", "description": "A