Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit and page fields to PubSub and Webhooks List RPC #7521

Open
wants to merge 2 commits into
base: v3.34
Choose a base branch
from

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Feb 26, 2025

Summary

References: #7418
References: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1222

This PR fixes the ApplicationPubSubRegistry/List and ApplicationWebhookRegistry/List default pagination limit feature.

Changes

  • Add limit and page fields to PubSub and Webhooks List RPC
  • Set pagination values in PubSub and Webhooks List RPC

Testing

Steps

See the test steps in #7418

Results
Regressions

...

Notes for Reviewers

This is fixes the issue found during release testing. https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1222#issuecomment-2684962799
Probably needs to cherry-pick to the v3.34 release branch.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi requested review from a team as code owners February 26, 2025 17:07
@halimi halimi self-assigned this Feb 26, 2025
@github-actions github-actions bot added the c/application server This is related to the Application Server label Feb 26, 2025
@halimi halimi added this to the v3.34.0 milestone Feb 26, 2025
@halimi halimi requested a review from KrishnaIyer February 26, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant