Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ns device registry validation #7495

Open
wants to merge 1 commit into
base: v3.34
Choose a base branch
from

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Jan 29, 2025

Summary

References: #7380

The NsEndDeviceRegistryServer.Set() function is more than 3k row long and it is hard to follow what it does. The biggest part is doing different kind of validations and this part can be split up and move out to different validator functions.

Changes

  • Split up the NsEndDeviceRegistryServer.Set() function validation part and move it out to validator functions.

Testing

Steps

The code logic haven't changed just restructured. The unit tests should pass.

Results
Regressions

Notes for Reviewers

The code logic haven't changed just moved out some part of the code to validator functions. This change will make it easier to validate the mac setting profile.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi self-assigned this Jan 29, 2025
@github-actions github-actions bot added the c/network server This is related to the Network Server label Jan 29, 2025
@halimi halimi added this to the v3.34.0 milestone Jan 29, 2025
@halimi halimi force-pushed the feature/refactor-ns-device-registry branch from f179451 to 47e145e Compare February 17, 2025 10:51
@halimi halimi force-pushed the feature/refactor-ns-device-registry branch from 47e145e to 4f5e831 Compare February 17, 2025 13:36
@halimi halimi marked this pull request as ready for review February 17, 2025 13:58
@halimi halimi requested a review from a team as a code owner February 17, 2025 13:58
@halimi halimi mentioned this pull request Feb 19, 2025
7 tasks
@halimi halimi modified the milestones: v3.34.0, v3.34.1 Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant