Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Bug With Glotter Build #3070

Closed
jrg94 opened this issue May 5, 2023 · 7 comments · Fixed by #3075
Closed

Weird Bug With Glotter Build #3070

jrg94 opened this issue May 5, 2023 · 7 comments · Fixed by #3075
Assignees
Labels
bug Something isn't working

Comments

@jrg94
Copy link
Member

jrg94 commented May 5, 2023

I assume this is a short term thing (like some dependency is down). On the off chance that it's not (like a dependency update broke Glotter), I figured I'd note it down here. I'll be attaching the log of the latest build shortly as well as the log of a recently working build for comparison.

@jrg94 jrg94 added the bug Something isn't working label May 5, 2023
@jrg94 jrg94 added this to Automation May 5, 2023
@github-project-automation github-project-automation bot moved this to To do in Automation May 5, 2023
@jrg94
Copy link
Member Author

jrg94 commented May 5, 2023

Okay, I literally can't attach the log because it's so large... (150 MB). Here are the dependency files at least.

@jrg94
Copy link
Member Author

jrg94 commented May 5, 2023

Okay, looks like requests updated from 2.29 to 2.30. That definitely seems like a potential issue. Let me peek at their repo.

Also, urllib upgraded from 1.26.15 to 2.0.2. That is more likely the culprit.

@jrg94
Copy link
Member Author

jrg94 commented May 5, 2023

Okay, the issue is definitely with requests as others are already seeing issues: psf/requests#6443

@jrg94
Copy link
Member Author

jrg94 commented May 5, 2023

A short term fix would be to constrain requests to 2.29.0 or constrail urllib2 < 2.

@jrg94
Copy link
Member Author

jrg94 commented May 5, 2023

Looks like there's more context here: psf/requests#6432

@jrg94
Copy link
Member Author

jrg94 commented May 5, 2023

I might go the poetry route with our build system as mentioned here: psf/requests#6432 (comment). The lockfile idea sure seems ideal to prevent this exact situation.

@rzuckerm
Copy link
Collaborator

rzuckerm commented May 6, 2023

It looks like docker 6.1.0 is compatible with urllib3 2.0. Perhaps, that will fix this problem without having to pin back urllib3

@github-project-automation github-project-automation bot moved this from To do to Done in Automation May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants