Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not require symfony/symfony to be present in composer.json #39

Open
fritzmg opened this issue May 18, 2019 · 11 comments
Open

do not require symfony/symfony to be present in composer.json #39

fritzmg opened this issue May 18, 2019 · 11 comments

Comments

@fritzmg
Copy link

fritzmg commented May 18, 2019

In some Symfony applications, like the Contao 4 Managed Edition, you will never have symfony/symfony or symfony/framework-bundle as a root dependency (neither of which are required anyway).

This extension should not rely on that.

@cbastienbaron
Copy link

instead of check sf/sf composer req, can we test if interface Psr\Container\ContainerInterface exist ?

@dasraab
Copy link

dasraab commented Jul 21, 2019

Got the same problem with pimcore framework (https://github.com/pimcore/pimcore) it uses composer merger plugin so same problem as above - symfony is not a root dependency in composer.json

@jaikdean
Copy link

Agreed. It should be fairly easy to look for the required individual Symfony packages in composer.lock. That way it doesn't matter if they're installed through symfony/symfony, symfony/framework-bundle, as individual packages or any anything else.

@WhoSayIn
Copy link

WhoSayIn commented Feb 5, 2020

Same here. We don't use symfony/symfony but use a lot of different components of symfony.

We should have another way of enabling the extension.

@JDDoesDev
Copy link

Has there been any movement on this? I'm trying to use it on a Drupal project where symfony isn't required in the root composer.json but instead in docroot/core/composer.json

@amaisano
Copy link

I'm desperate for this in my Drupal 8.x project. Symfony/Console is present, but not the special console script.

@amaisano
Copy link

I wonder if we can leverage drupal/console, which is a fork of symfony/console? It has a debug:container command...

@oojacoboo
Copy link

To be honest, there doesn't seem much desire to provide this. So, unless someone plans to submit a PR, I wouldn't expect the maintainers to get on it.

@amaisano
Copy link

We'd need something to "bridge" the gap like https://github.com/Haehnchen/idea-php-drupal-symfony2-bridge does for PHP Storm. I'm working on a fork to parse drupal/console debug:container instead of symfony/console, but it's not going to be easy.

@oojacoboo
Copy link

@amaisano any progress on that fork?

@JProffitt71
Copy link

JProffitt71 commented Aug 16, 2023

Symfony's default installation through the symfony init command no longer includes symfony/symfony as a dependency, and in fact marks it as a conflict.

There needs to be a way to either ignore the requirement or have it fallback to detecting individual packages like symfony/console and symfony/framework-bundle.

Edit: Apparently it does check for symfony/framework-bundle. I'm noticing some errors in the extension host log so I am going to investigate those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants