-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue Panel Implementation #22
Comments
Or just store in |
Some additional ideas for Recent Extraction Panel -
|
Some projects on reading the shell outputs. https://github.com/JohnSundell/ShellOut |
The problem is that the output folders are stored in a user defined location, therefore they could be deleted or moved. I suggest we instead scan the destination folder, and use that. @orchetect if we decide to do it this way there should be an option to place the result file into the output folder, this way I can get the profile information (notion, airtable). Also it would be nice if you add export date to the result file if you haven't already.
The current fixed window size will be too small for this I think. Even if user can resize each column. |
Already possible. Use the
I'll add it to the to-do list. I'm also adding MarkersExtractor version to the result file too, which may help with debugging. |
Done - Will be in MarkersExtractor 0.2.9. Date is ISO8601 formatted. |
Also added CLI/library version number to the result file (TheAcharya/MarkersExtractor#75 (comment)). Will be in MarkersExtractor 0.2.9. |
Not sure if this approach would make sense or be possible. Just ideas. Made a quick mockup in Photoshop. Under Recent Extraction Panel we would have 2 tabs. "Database Profiles" and "Extract Only". In Database Profiles tab, only profiles with Notion or Airtable will be filtered and listed. In each item row, users can select their particular Database Profiles which they have created in the Database Panel. There is also a "None" option, should they wish not to upload. Users would be able to right-click any row time to reveal in finder. In Extract only tab, all non Notion or Airtable profiles will get listed. Since no upload is required, the upload and status column is not shown. That way we can maximise our fixed window size. You call enable horizontal scrollbar when user resize each column? |
@milanvarady We can use clock icon from SF icon library for the side panel. |
@milanvarady Some ideas for the Recent Extraction Panel. Now that we have Share Destination in place. I am thinking how we can utilise Share Destination in conjunction with “Recent Extraction Panel” to stream line the process. As user send their timeline to Marker Data via Share Destination or via manually method from Extract Panel. What if we can keep track of it.
If user switches to another configuration where the Export Destination is at a different location, Marker Data would automatically rescan and read the |
@milanvarady I have another approach for the Recent Extraction Panel. We can call it
User can utilise the |
@IAmVigneswaran This how I image it.
And I think "Upload Queue" makes more sense, it conveys its function better than just "Recent Extractions". |
But the We also need to have the ability where users can manually drag and drop the folders into the Queue Panel.
We can have an upload limit at ay given time. Maybe 30sec to 1 min interval between each upload.
We can call it just |
We can save the result file inside the folder.
I don't think we need a file that stores cumulative information. We can just scan the folder each time, this way we have up-to-date information all the time.
Maybe instead of drag and dropping, users can change the destination folder. I can add the destination folder picker into the Queue panel. |
That would be great! Cause there is a small different between Notion and Airtable profile type and their json data.
Typo. I meant to say, "and the
That could work too. |
@orchetect I asked you before to add an option to include the result file inside the outputted folder. You said this:
The problem is that as far as I know, I can't get the |
Yes that's right, MarkersExtractor is determining the actual output folder during the extraction process. Originally, one of the main purposes of the result file was to give you information such as the actual output folder. So saving the result file to the output folder itself is somewhat redundant and actually problematic, which is why we changed the CLI flag from result file name to result file path. If you want, open a new issue on MarkersExtractor for adding an option to output the result file to the output folder. |
@orchetect I just want to know the extraction profile basically. I need to know if the JSON should be uploaded to Notion or Airtable. So I'm fine with any sort of way of figuring that out. Maybe add a key to the JSON called "platform" that I can use? |
The |
@orchetect I forgot that the |
@IAmVigneswaran The Queue is ready! In the table, you can see the file's name, creation date, and export profile. Then comes the upload destination selector, you can either leave it on At the bottom, you can enable |
@milanvarady Thanks for Implementing the Queue Panel! Looks awesome! But there are few behavioural and logic tweaks that needs to be addressed.
I believe we need to add a That way, when users drag & drop any data set folders (1 or more) or presses |
@IAmVigneswaran Some of the tweaks you mention are already implemented. Let me explain how the queue works. After the export, I save an extra JSON file inside the extracted folder called One thing to note is that if you have some folders that were extracted before I implemented the Queue, they won't show up in the UI as they don't have the So knowing that let's address the tweaks.
Added.
I aligned it to the right because it's not always visible. If it is next to the
This makes no sense to me. The list reflects the folders inside the export folder. Why would we want to clear it?
This is already how it works. Each time you open the Queue panel it scans the folder.
I added sorting options.
We can load it back very easily. If you set the
I think it's easier if users just change the export destination. I can add the export destination picker to the Queue panel maybe. |
@milanvarady Thanks for the updates and improvements.
That is understandable! 👍
Let's make the
Thank you! 👍
It does makes sense. It is about specificity and focus. Example - In FCP, Say if I have 20 timeline, that I have used (Notion (No Upload0) for extraction first. I would have 20 items listed in Queue panel. But say I only want to selectively
it is not very clear to the user? Maybe a
|
@IAmVigneswaran Then maybe by default we show items from the export destination folder (how it works now), and I add the option to drag & drop folders onto the table. When the user drag & drop I overwrite the folders loaded from the export destination and only show the dropped ones. I can also add a |
That would work too. But for some users, they might want to maintain the and keep the Data Set in the
That would be great! |
@IAmVigneswaran I don't understand what you mean by this clear button. What would it clear? Because if it clears the whole table, it will be empty obviously. Maybe you mean to clear before the user drags some other folders onto the table? When the user drag & drops some folders I imagine it would replace the table. In other words clear first then load the new ones. |
Yes. It would clear the table, to make it empty. It can be a button or in right-click menu, there is a
We would also have this automatic behaviour to But we need to have manual |
@milanvarady Is it possible for Queue panel to remember the column width adjustments? |
@IAmVigneswaran We now have drag & drop. You can drag any number of folders, each will be scanned recursively for You can clear by right-clicking the table. |
@milanvarady Thanks for implementing it.
Right now when Can we add another behaviour where holding |
Tweak @milanvarady I understand that the the
|
@IAmVigneswaran Recursive scanning means that each folder within the parent folder is scanned. I think what you mean is that it is scanned automatically. The way it works now is that when you open the queue and the table is empty, the export destination is automatically scanned. So you want to disable automatic scanning? |
@milanvarady Yeap. Can we have an option to disable automatic scanning? Cause at the moment, even when I press Are we able to link If users want to Enable automatic scanning back, they would click, |
@IAmVigneswaran Unfortunately, it doesn't seem to be possible to remember the column width. I found 3 parameters you can set considering table column width.
Maybe we can tweak the ideal width of the table columns to be better. |
Not really. I didn't find a way to add key modifiers to a drop area. |
I added a flag so when you clear it disables automatic scanning. Pressing the |
I have changed the behavior. Check again. |
@IAmVigneswaran I have added tooltips for the name and date. |
Thank you! |
Continuing the discussion from -
#16 (comment)
#16 (comment)
#16 (comment)
A basic mock-up for Recent Extraction Panel.
We can keep track of all the recent extractions.
Few Ideas -
result json file
keep Marker Data's own cumulative recent file in/Users/UserID/Library/Application Support/Marker Data/recent.json
?recent.json
file?The text was updated successfully, but these errors were encountered: