Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building version 2.7 in Carthage fails #1004

Open
edopelawi opened this issue Jul 3, 2018 · 11 comments
Open

Building version 2.7 in Carthage fails #1004

edopelawi opened this issue Jul 3, 2018 · 11 comments

Comments

@edopelawi
Copy link

edopelawi commented Jul 3, 2018

Dear all,

I tried to install Texture version 2.7 through Carthage today and failed. Version 2.6 still works fine, though. I'm using Carthage version 0.30.1 and Xcode 9.4.1, and used carthage bootstrap --cache-builds to install Texture.

I'm not sure whether this will help, but this is the error log I got from the building process:

Build Failed
Task failed with exit code 65:
/usr/bin/xcrun xcodebuild -workspace /Users/[REDACTED]/Carthage/Checkouts/texture/AsyncDisplayKit.xcworkspace -scheme AsyncDisplayKit -configuration Release -derivedDataPath /Users/[REDACTED]/Library/Caches/org.carthage.CarthageKit/DerivedData/9.4.1_9F2000/texture/2.7 -sdk iphonesimulator -destination platform=iOS\ Simulator,id=28F06456-6D68-4151-9D2D-0C43D79CCF3D -destination-timeout 3 ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES build (launched in /Users/[REDACTED]/Carthage/Checkouts/texture)

Thanks in advance!

@fumito-ito
Copy link

I have same issue. In my Cartfile.resolved has a strange reference for Texture like github "texturegroup/texture" "show". Is there any problem?

@rainypixels
Copy link
Contributor

I think you're hitting the same issue as this one that I filed a couple of months ago: #873

@Saik0s hack has been working for me, but I'm going to be throwing in the towel and installing Texture via cocoapods because carthage support for Texture has always been somewhat poor (especially this year; if you're interested, you can look for a thread on the slack that I started with the core team).

In any case, give that script a shot. I build Texture via that script, and the rest of my cartfile dependencies the usual way (carthage update --platform iOS).

@edopelawi
Copy link
Author

@rainypixels, thanks for the suggestion! I don't think I could go with Cocoapods this time... I guess I'll try @Saik0s hack, then.

@edopelawi
Copy link
Author

@rainypixels hey your suggestion works! Thanks a bunch!

I wonder whether I should close this issue or not, though...

@rainypixels
Copy link
Contributor

@edopelawi I’d been holding off on switching to cocoapods, but I just did it this evening. My project now has two dependency managers: cocoapods for Texture, and Carthage for everything else. So far it’s not too bad. One thing worth mentioning: image caching doesn’t work at all when Texture is integrated through Carthage. It’s the main reason I’ve been nudging the Texture team to make Carthage support a first-class citizen.

@edopelawi
Copy link
Author

Really? That's a real bummer! Do you know which part that responsible for image caching? If possible, we might be able to create a pull request for proper Carthage support...

@Saik0s
Copy link

Saik0s commented Jul 6, 2018

I am using #888 to support image caching when installing using Carthage

@rainypixels
Copy link
Contributor

@edopelawi See @Saik0s pointer. Also, here's a long-standing issue on the same topic.

@fumito-ito
Copy link

fumito-ito commented Jul 27, 2018

@Adlai-Holler this problem looks resolved by 7c1aee7 . Can core team release hot fix like 2.7.1 for carthage users ?

@ermik
Copy link

ermik commented Nov 10, 2018

@TextureGroup @ay8s do you guys think this can be attended to?

@AgileFlex
Copy link

Is there a fix for building the AsyncDisplayKit.framework in xCode 10 for branch "texturegroup/texture"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants