Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute Type Validation at the Front End #1889

Closed
aahei opened this issue Apr 24, 2023 · 2 comments · Fixed by #1924
Closed

Attribute Type Validation at the Front End #1889

aahei opened this issue Apr 24, 2023 · 2 comments · Fixed by #1924
Assignees

Comments

@aahei
Copy link
Contributor

aahei commented Apr 24, 2023

New feature: Attribute Type Validation in Workflow Editor

Problem: Most operators only take input attributes of particular types for their fields. For example, the sentiment analysis operator only accepts string-typed attributes as input. However, there isn't any type-checking mechanism at the front end to check the type of attributes users selected, and they can't find the error until they run the workflow.

Solution: Implement the attribute type validation at the front end using the type constraint information from the schema from the back end. That is, accepted attribute type information is transmitted within the operators' schemas and enforced at the front end, which requires changing the operator schema structure. It involves using formly at the front end and modifying the Jackson JSON Schema Generator library at the back end.

@aahei aahei changed the title Attribute Type Validation in Workflow Editor Attribute Type Validation at the Front End Apr 24, 2023
@aahei aahei self-assigned this Apr 24, 2023
@aahei
Copy link
Contributor Author

aahei commented Jun 24, 2023

There will be a third PR adding the attribute type rules for the rest operators when they have been fixed in #1954 , #1955 .

@shengquan-ni
Copy link
Collaborator

No critical need for this, close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants