Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci launch parameters #293

Closed
wants to merge 15 commits into from
Closed

Ci launch parameters #293

wants to merge 15 commits into from

Conversation

TerrenceMcGuinness-NOAA
Copy link
Owner

Description

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES/NO
  • Does this change require a documentation update? YES/NO

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 16, 2024
View reviewed changes
ci/scripts/utils/launch_job.sh Outdated
build_url="${controller_url}/job/${project_name}/job/${job_name}/job/${pr_number}/buildWithParameters?delay=0sec"

echo ""
echo $build_url

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
ci/scripts/utils/launch_job.sh Outdated
build_url="${controller_url}/job/${project_name}/job/${job_name}/job/${pr_number}/buildWithParameters?delay=0sec"

echo ""
echo $build_url

Check notice

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note

Prefer putting braces around variable references even when not strictly required.
ci/scripts/utils/launch_job.sh Outdated
echo $build_url
echo ""

curl -sSL "${contoller_url}/pluginManager/api/json?depth=1" -u $username:$api_token ${build_url}

Check notice

Code scanning / shellcheck

Prefer double quoting even when variables don't contain special characters. Note

Prefer double quoting even when variables don't contain special characters.
ci/scripts/utils/launch_job.sh Outdated
echo $build_url
echo ""

curl -sSL "${contoller_url}/pluginManager/api/json?depth=1" -u $username:$api_token ${build_url}

Check notice

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note

Prefer putting braces around variable references even when not strictly required.
ci/scripts/utils/launch_job.sh Outdated
echo $build_url
echo ""

curl -sSL "${contoller_url}/pluginManager/api/json?depth=1" -u $username:$api_token ${build_url}

Check notice

Code scanning / shellcheck

Prefer double quoting even when variables don't contain special characters. Note

Prefer double quoting even when variables don't contain special characters.
ci/scripts/utils/launch_job.sh Outdated

exit

curl -X POST ${build_url} --user $username:$api_token ${build_url} --data-urlencode "Node=${node}" --data-urlencode "machine=${machine_name}"

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
ci/scripts/utils/launch_job.sh Outdated

exit

curl -X POST ${build_url} --user $username:$api_token ${build_url} --data-urlencode "Node=${node}" --data-urlencode "machine=${machine_name}"

Check notice

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note

Prefer putting braces around variable references even when not strictly required.
ci/scripts/utils/launch_job.sh Outdated

exit

curl -X POST ${build_url} --user $username:$api_token ${build_url} --data-urlencode "Node=${node}" --data-urlencode "machine=${machine_name}"

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
ci/scripts/utils/launch_job.sh Outdated

exit

curl -X POST ${build_url} --user $username:$api_token ${build_url} --data-urlencode "Node=${node}" --data-urlencode "machine=${machine_name}"

Check notice

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note

Prefer putting braces around variable references even when not strictly required.
ci/scripts/utils/launch_job.sh Outdated

exit

curl -X POST ${build_url} --user $username:$api_token ${build_url} --data-urlencode "Node=${node}" --data-urlencode "machine=${machine_name}"

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TerrenceMcGuinness-NOAA