Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should type hints for Atom be IAtom? #102

Closed
snoe opened this issue Jun 4, 2022 · 1 comment
Closed

Should type hints for Atom be IAtom? #102

snoe opened this issue Jun 4, 2022 · 1 comment

Comments

@snoe
Copy link

snoe commented Jun 4, 2022

Trying to implement reagent style cursors just to see if it'll work and when passed to the flutter helperwidget :watch I receive this error:

The following _CastError was thrown building _BodyBuilder:
type 'RCursor' is not a subtype of type 'Atom' in type cast

I believe this means that add-watch and other atom related functions should be hinted to IAtom rather thanAtom

[^Atom reference key fn]

@cgrand
Copy link
Contributor

cgrand commented Jun 4, 2022

There should be no type hints at all here. And add-watch should just be an inline of -add-watch

@cgrand cgrand closed this as completed in f7d47cb Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants