Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make description field optional for Highlghted Cards #1673

Closed
2 tasks done
yceballost opened this issue Feb 22, 2024 Discussed in #1657 · 1 comment · Fixed by Telefonica/mistica-web#1039
Closed
2 tasks done

Make description field optional for Highlghted Cards #1673

yceballost opened this issue Feb 22, 2024 Discussed in #1657 · 1 comment · Fixed by Telefonica/mistica-web#1039

Comments

@yceballost
Copy link
Collaborator

yceballost commented Feb 22, 2024

Discussed in #1657

Originally posted by carlosgarciaibanez February 19, 2024

Goal

We want to simplify the management of this type of components, it doesn't seem to make much sense to have a mandatory description in a component like this.

Context

We are currently using the Highlighted Cards for modules that do not require a description, like our Airtime Rewards module:
image
To achieve this, we are currently setting the description field to a blank space, but this is a brittle and problematic solution.
The proper way to go would be to make the field completely optional.

Impact

This will simplify things and will allow us to remove some dirty hacks.

Discussion Questions

  • Why was the reason to make the description field mandatory in this component?
  • If that is a compelling reason, why did we allow these modules without a description on them?

Additional considerations

No response

Do you have a visual proposal?

No response

@aweell
Copy link
Collaborator

aweell commented Feb 22, 2024

The documentation has already been updated in #1650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment