Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Sizes | Theme Context #1669

Closed
annefranca opened this issue Feb 20, 2024 · 1 comment
Closed

Icon Sizes | Theme Context #1669

annefranca opened this issue Feb 20, 2024 · 1 comment
Labels
bug 🐞 Something isn't working
Milestone

Comments

@annefranca
Copy link
Collaborator

annefranca commented Feb 20, 2024

Describe the bug

Quando alteramos o Theme Context para Inverse no tema Vivo New, alguns ícones não estão atribuindo a o token de cor definido para cada contexto.

What libraries are you seeing the problem on?

Vivo Library

Steps to reproduce

https://www.figma.com/file/seiNjy7YmPWEY3BfY4WYpp/Estudos?type=design&node-id=2410%3A523&mode=design&t=7BAY3rIyJ8VWfhIU-1

Expected behavior

Ao alterar para o Theme Context = Inverse, o token atribuído deve ser "inverse".

@annefranca annefranca added the bug 🐞 Something isn't working label Feb 20, 2024
@annefranca annefranca changed the title Icon Sizes | Theme Context Inverse Icon Sizes | Theme Context Feb 20, 2024
@yceballost yceballost added this to the 13.1.0 milestone Apr 1, 2024
@aweell
Copy link
Collaborator

aweell commented Apr 12, 2024

Hi @annefranca,

The issue seems to be mostly related to themer rather than the component iconSizes

In order to achieve icons in inverse in another theme the steps should be

  1. Change the default icon to inverse
  2. Change the size if needed
  3. Replace the icon with the icon you want to use
  4. Use themer

following that steps should ensure all icons behave as expected

@aweell aweell closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants