-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Border Radius in small elements #1474
Comments
I had an idea: One possibility is to use different Variants, creating variants for Cards and another for smaller components such as images. Using the variants is even easier and has fewer sudden changes. |
Prop en la imagenEsta opción la verdad es que me parece la peor de todas y que es una puerta a inconsistencias que evitaría abrir si es posible Buscar un valor que valga para los dos escenariosEsto podría ser una solución salomónica al problema, un contra es que haya casos en los que imágenes y containers vayan de la mano, donde se verá un border radius diferente entre ellas y quizás no sea lo mas adecuado? Utilizar un contextoOtra idea es que las imágenes que vayan dentro de determinados componentes (como las listas) beban de un contexto que les diga, ahí píntate con un radius mas pequeño. Esta definición podría venir por token en cada marca o ser un valor fijo para todas Valor fijo: https://tinyurl.com/ykeap2h3 Problemas de esto:
En principio los componentes a los que debería aplicar son listas, acordeones, footer de la advanced data card y variante imagen squared del stacking group |
@aweell |
In Figma depends on what other brands define:
|
PR on going in Mística web |
I took this task. Merged in mobile and desktop in Figma |
Description
Brands with big border radius applying in elements like "images" works bad in small sizes.
https://tinyurl.com/2cylf4jz
Components affected
Tasks
The text was updated successfully, but these errors were encountered: