Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border Radius in small elements #1474

Closed
5 of 7 tasks
yceballost opened this issue Sep 27, 2023 · 6 comments
Closed
5 of 7 tasks

Border Radius in small elements #1474

yceballost opened this issue Sep 27, 2023 · 6 comments

Comments

@yceballost
Copy link
Collaborator

yceballost commented Sep 27, 2023

Description

Brands with big border radius applying in elements like "images" works bad in small sizes.
https://tinyurl.com/2cylf4jz

Components affected

  • Lists
  • Accordion
  • Stacking group
  • Cards asset (squared images)
  • Callout
  • Community/Blocks/SimpleBlock
  • Community/AdvancedDataCard
  • .resources/DataCardAdvanced/Footer

Tasks

@LucasAlbuquerque0
Copy link

I had an idea: One possibility is to use different Variants, creating variants for Cards and another for smaller components such as images. Using the variants is even easier and has fewer sudden changes.
@yceballost

@yceballost yceballost modified the milestones: 11.1.0, 11.2.0 Oct 11, 2023
@aweell
Copy link
Collaborator

aweell commented Oct 26, 2023

Prop en la imagen

Esta opción la verdad es que me parece la peor de todas y que es una puerta a inconsistencias que evitaría abrir si es posible

Buscar un valor que valga para los dos escenarios

Esto podría ser una solución salomónica al problema, un contra es que haya casos en los que imágenes y containers vayan de la mano, donde se verá un border radius diferente entre ellas y quizás no sea lo mas adecuado?

Utilizar un contexto

Otra idea es que las imágenes que vayan dentro de determinados componentes (como las listas) beban de un contexto que les diga, ahí píntate con un radius mas pequeño.

Esta definición podría venir por token en cada marca o ser un valor fijo para todas

Valor fijo: https://tinyurl.com/ykeap2h3

Problemas de esto:

  • Si se utilizan imágenes fuera de los componentes donde se defina que van así, en tamaños pequeños seguirán teniendo el mismo problema.
  • El uso de imagenes fuera de los componentes que se haya indicado que el contexto deba aplicar no se verán afectados por este cambio

En principio los componentes a los que debería aplicar son listas, acordeones, footer de la advanced data card y variante imagen squared del stacking group

@LucasAlbuquerque0
Copy link

@aweell
The code solution will be when the object is inside a container using an 8px border and 16px outside the default. Correct?
In figma, it will be the creation of two new variables, one for container and another for when it is inside a container, would that be it?

@yceballost yceballost modified the milestones: 11.2.0, 11.4.0 Oct 30, 2023
@aweell
Copy link
Collaborator

aweell commented Oct 31, 2023

@LucasAlbuquerque0

In Figma depends on what other brands define:

  • If the definition differs between brands, a new token and variable will be created for figma and the default image radii will be overrided in the instances of the component image used in the affected components.
  • If the same value works for all brands there's no need of a new variable

@aweell aweell modified the milestones: 11.4.0, 12.0.0 Nov 22, 2023
@aweell aweell changed the title Border Radius in small elements [Pending Implementation] Border Radius in small elements Nov 27, 2023
@yceballost yceballost changed the title [Pending Implementation] Border Radius in small elements Border Radius in small elements Dec 5, 2023
@yceballost
Copy link
Collaborator Author

PR on going in Mística web

@yceballost
Copy link
Collaborator Author

I took this task. Merged in mobile and desktop in Figma

@yceballost yceballost self-assigned this Dec 7, 2023
@yceballost yceballost moved this from Backlog to Done in Mística Design System Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants