Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change border of the unselected chip #1213

Closed
8 tasks done
AnaMontes11 opened this issue Apr 28, 2023 · 2 comments · Fixed by Telefonica/mistica-web#744
Closed
8 tasks done

Change border of the unselected chip #1213

AnaMontes11 opened this issue Apr 28, 2023 · 2 comments · Fixed by Telefonica/mistica-web#744
Assignees
@AnaMontes11
Labels
category: documentation changelog: changed component: chip library: desktop library: mobile
Milestone
8.2.0

Comments

@AnaMontes11
Copy link
Contributor

AnaMontes11 commented Apr 28, 2023 •
edited
Loading

Description

Change the color of the unselected chip container border from border to control.

The reason for this change is that, in darkMode, the chips currently use darkModeGrey for the border and backgroundContainer. As such, visibility is lost. This change resolves this issue.

Captura de Pantalla 2023-05-05 a las 11 28 19

Tasks

  • Update specs
  • Design documentation
  • Add to mobile library
  • Add to desktop library
  • Add to UI Kit
  • Android ticket
  • iOS ticket
  • Web ticket
@AnaMontes11 AnaMontes11 self-assigned this Apr 28, 2023
@AnaMontes11 AnaMontes11 moved this from Backlog to In progress (specs) in Mística Design System Apr 28, 2023
@AnaMontes11 AnaMontes11 added this to the 8.1.2 milestone Apr 28, 2023
@yceballost yceballost linked a pull request May 4, 2023 that will close this issue
fix(Chip): improve border color in dark mode Telefonica/mistica-web#744
Merged
@yceballost
Copy link
Collaborator

please, include in the description of the issue the reason why of this change

@AnaMontes11
Copy link
Contributor Author

please, include in the description of the issue the reason why of this change

Done. Thanks

@AnaMontes11 AnaMontes11 moved this from In progress (specs) to Done in Mística Design System May 5, 2023
@yceballost yceballost moved this from Done to Released in Mística Design System May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnaMontes11 AnaMontes11

Labels
category: documentation changelog: changed component: chip library: desktop library: mobile
Projects
Mística Design System
Status: Released
Milestone
8.2.0
Development

Successfully merging a pull request may close this issue.

fix(Chip): improve border color in dark mode Telefonica/mistica-web
2 participants
@yceballost @AnaMontes11