I posted 2 Pull Requests (a couple of typos found) to the Github/omnirom/android_bootable_recovery

[ghost]

Hi all,
I posted 2 Pull Requests (a couple of typos found) to the Github/omnirom/android_bootable_recovery.
I found them in English and in German.

omnirom/android_bootable_recovery#156
omnirom/android_bootable_recovery#155

Is this correct? Will they be approved and merged to be fixed in the next release or must I post them somewhere else?
My device is: Samsung Galaxy S5 SM-G900F (klte), but I suppose the typos affect all devices.

Would be happy for a short reply... :-)

Pierre

[nailyk-fr]

Github PR are not merged.
Only reviewed/merged with the gerrit instance.
https://gerrit.omnirom.com for twrp
https://gerrit.twrp.me for some specific devices trees.

[ghost]

Thanks for the reply. Do I need to do anything special, or will somebody take care automatically sometime of my Pull Requests?

[nailyk-fr]

No auto import :s
You should be able to find process on internet. It is a bit heavy the first times.
Basically you need to rebase your work on top of the current tree, add the 'change-ID' into each commit message, then push to gerrit.
Good luck

[ghost]

Hmm... The only thing I don't understand is, why is the TWRP page referring to report bugs and stuff here at Github?
I hope one of the devs sees this and can place the two mentioned upper reports to the right place for a fix.

[CaptainThrowback]

Github is being used to track issues - that's all. For code changes, you need to submit through the OmniROM Gerrit. Pull requests through Github will never be merged.

[ghost]

Since I'm pretty new to these kind of things - it's more like a hobby to me. I'm fully able to flash TWRP to my Samsung device, Install LineageOS and GApps - that's all not a big deal, but this is different dimension I think. I hope someone could do this little job for me, or maybe even one of the devs, if they are looking in into Github posts as well... I just discovered a few typos in English and German in the latest TWRP and wanted to have this corrected/changed...
But thanks to everyone for commenting :-)

[CaptainThrowback]

If you're able to submit a pull request, you should be able to push to Gerrit. You seem to think that it's more difficult than it actually is. Here are the instructions: https://github.com/omnirom/android/blob/android-7.1/README.md

[nailyk-fr]

Does a specific tool exist for translation problem instead of pushing change @CaptainThrowback ?
Maybe something like weblate?
BTW I made a PR to add a PR template which warn about gerrit.