From 4ef9ee04c917e6fed90007e28d81935728ef945a Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Sat, 29 Jun 2024 16:06:18 +1000 Subject: [PATCH 1/6] ci: Try to use Node 20 for CSB --- .codesandbox/ci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index 75bde4e176..f15db8160b 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -9,5 +9,5 @@ "/examples/vue/basic" ], "packages": ["packages/**"], - "node": "18" + "node": "20" } From 62cb4b8f34eab817a73700296e2ed9577a964958 Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Sat, 29 Jun 2024 16:09:56 +1000 Subject: [PATCH 2/6] Simplify install/build scripts --- .codesandbox/ci.json | 4 ++-- package.json | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index f15db8160b..dfba25587f 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,6 +1,6 @@ { - "installCommand": "install:csb", - "buildCommand": "build:csb", + "installCommand": "pnpm install --frozen-lockfile", + "buildCommand": "nx run-many --target=build --exclude=examples/** --exclude=integrations/**", "sandboxes": [ "/examples/angular/basic", "/examples/react/basic-typescript", diff --git a/package.json b/package.json index d5ace070e3..ccd4645a8e 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,6 @@ "clean": "pnpm --filter \"./packages/**\" run clean", "preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...')} else {process.exit(1)}\" || npx -y only-allow pnpm", "prepare": "husky", - "install:csb": "corepack enable && pnpm install --frozen-lockfile", "test": "pnpm run test:ci", "test:pr": "nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw", "test:ci": "nx run-many --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw", @@ -26,7 +25,6 @@ "test:knip": "knip", "build": "nx affected --target=build --exclude=examples/**", "build:all": "nx run-many --target=build --exclude=examples/**", - "build:csb": "nx run-many --target=build --exclude=examples/** --exclude=integrations/**", "watch": "pnpm run build:all && nx watch --all -- pnpm run build:all", "dev": "pnpm run watch", "prettier": "prettier --ignore-unknown '**/*'", From 82b1f7403619d74e1717c31eb44724e067800a3f Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Sat, 29 Jun 2024 16:10:56 +1000 Subject: [PATCH 3/6] Fix installCommand --- .codesandbox/ci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index dfba25587f..541bfbda6b 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,5 @@ { - "installCommand": "pnpm install --frozen-lockfile", + "installCommand": "install --frozen-lockfile", "buildCommand": "nx run-many --target=build --exclude=examples/** --exclude=integrations/**", "sandboxes": [ "/examples/angular/basic", From 5a9b397edeff18778ce006a47ffd8cb5b7704168 Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Sat, 29 Jun 2024 16:11:45 +1000 Subject: [PATCH 4/6] Remove installCommand --- .codesandbox/ci.json | 1 - 1 file changed, 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index 541bfbda6b..0edd09b1b3 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,4 @@ { - "installCommand": "install --frozen-lockfile", "buildCommand": "nx run-many --target=build --exclude=examples/** --exclude=integrations/**", "sandboxes": [ "/examples/angular/basic", From a1c3b9355dbbb294f95d4b0d122b92db770da036 Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Sat, 29 Jun 2024 16:13:22 +1000 Subject: [PATCH 5/6] Undo --- .codesandbox/ci.json | 3 ++- package.json | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index 0edd09b1b3..f15db8160b 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,6 @@ { - "buildCommand": "nx run-many --target=build --exclude=examples/** --exclude=integrations/**", + "installCommand": "install:csb", + "buildCommand": "build:csb", "sandboxes": [ "/examples/angular/basic", "/examples/react/basic-typescript", diff --git a/package.json b/package.json index ccd4645a8e..2c0b31a1ed 100644 --- a/package.json +++ b/package.json @@ -11,6 +11,7 @@ "clean": "pnpm --filter \"./packages/**\" run clean", "preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...')} else {process.exit(1)}\" || npx -y only-allow pnpm", "prepare": "husky", + "install:csb": "pnpm install --frozen-lockfile", "test": "pnpm run test:ci", "test:pr": "nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw", "test:ci": "nx run-many --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw", @@ -25,6 +26,7 @@ "test:knip": "knip", "build": "nx affected --target=build --exclude=examples/**", "build:all": "nx run-many --target=build --exclude=examples/**", + "build:csb": "nx run-many --target=build --exclude=examples/** --exclude=integrations/**", "watch": "pnpm run build:all && nx watch --all -- pnpm run build:all", "dev": "pnpm run watch", "prettier": "prettier --ignore-unknown '**/*'", From 4302188abd9616c664cb613c8d653323c01e0d45 Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Sat, 29 Jun 2024 16:14:31 +1000 Subject: [PATCH 6/6] Remove install:csb --- .codesandbox/ci.json | 1 - package.json | 1 - 2 files changed, 2 deletions(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index f15db8160b..ba5a486c61 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,4 @@ { - "installCommand": "install:csb", "buildCommand": "build:csb", "sandboxes": [ "/examples/angular/basic", diff --git a/package.json b/package.json index 2c0b31a1ed..b9712c09fb 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,6 @@ "clean": "pnpm --filter \"./packages/**\" run clean", "preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...')} else {process.exit(1)}\" || npx -y only-allow pnpm", "prepare": "husky", - "install:csb": "pnpm install --frozen-lockfile", "test": "pnpm run test:ci", "test:pr": "nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw", "test:ci": "nx run-many --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw",