Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting a player from round robbin when they lose their last country #13

Open
CloudandReact opened this issue Nov 30, 2015 · 4 comments
Assignees

Comments

@CloudandReact
Copy link
Collaborator

When a player is attacked on their last country they should be deleted from round robbin and also cards should be given to the opponent attacker.

@stewartadam
Copy link
Collaborator

When switching turns in the driver, we can check if a player has no countries - something like:

if (this->riskMap->getCountriesOwnedByPlayer(nextPlayer).size () == 0) {
  // skip
}

@EliHar-zz
Copy link
Collaborator

Once the attacker wins the country, I'm actually checking if the defender (loser) has any countries left in order to process the transfer of cards from winner to loser. Maybe the logic could be implemented there as well

@stewartadam
Copy link
Collaborator

I think that makes the most sense, it would eliminate all the temp variables too!

On Dec 2, 2015, at 12:39 AM, Elias Haroun notifications@github.com wrote:

Once the attacker wins the country, I'm actually checking if the defender (loser) has any countries left in order to process the transfer of cards from winner to loser. Maybe the logic could be implemented there as well


Reply to this email directly or view it on GitHub.

@TaimoorRana
Copy link
Owner

Okay, I'll add it there

@ghost ghost changed the title deleting a player from round robbin when he losses last country deleting a player from round robbin when they lose their last country Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants