-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vscode): use codelens for inline edit actions / decorations #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ract InlineEditController
…ol.d.ts on success, to help trigger watch mode of vscode extension
53c23bb
to
4989150
Compare
wsxiaoys
commented
Aug 28, 2024
@@ -26,7 +26,8 @@ | |||
"types": "./dist/protocol.d.ts", | |||
"scripts": { | |||
"build": "tsup --minify", | |||
"watch": "tsup --watch", | |||
"watch": "tsup --watch --onSuccess \"echo '' >> dist/protocol.d.ts\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icycodes this is a hack to trigger pnpm watch for vscode
… possible so codelens can display immediately
icycodes
approved these changes
Aug 29, 2024
icycodes
pushed a commit
that referenced
this pull request
Sep 2, 2024
) * refactor(vscode): disable noUnusedLocals and update build script. Extract InlineEditController * refactor(inline-edit): reorganize InlineChatEdit * restructure tsconfig.json * build(clients/tabby-agent): update watch script to modify dist/protocol.d.ts on success, to help trigger watch mode of vscode extension * streaming at line break * Let CodeLensProvider using footer's markers * turn off background color of header / footer to avoid flickering * support cancel from codelens * update * update * update * update * [autofix.ci] apply automated fixes * fix * chore(agent): when apply inline edit, apply the first edit as soon as possible so codelens can display immediately * add highlight for in progress edit * update * [autofix.ci] apply automated fixes * update --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Sma1lboy
https://jam.dev/c/f74c169c-f702-4e62-9ba8-27365a7a8993