Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNG outputs should be validated #719

Open
joeytakeda opened this issue Dec 3, 2024 · 1 comment
Open

RNG outputs should be validated #719

joeytakeda opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels
conversion: odd conversion: relax status: blocked Issue cannot be fixed until another issue is fixed (put that issue # in the comments).

Comments

@joeytakeda
Copy link
Contributor

Per TEIC/TEI#2538, as there may be some constructs that break RNG (but are near impossible to validate in ODD), it would be useful to ensure that the RNG file is valid and works before outputting it to the user.

@sydb suggested that the build process first checks that the RNG works, reads any error messages, and, if there are any, outputs those to the user (perhaps catching these errors in some way to give a more useful explanation) and then then deletes the temporary file.

I would also suggest that we allow some sort of switch (or re-use an existing one, like --debug) so that the temporary file is retained so the user can inspect that broken file, if they'd like.

@sydb
Copy link
Member

sydb commented Feb 11, 2025

This is not truly BLOCKED, but ATOP is going to do this, anyway. So assignee (@joeytakeda) plans to see how this is handled there first, and then unblock this issue and address it, possibly by copying code, possibly not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conversion: odd conversion: relax status: blocked Issue cannot be fixed until another issue is fixed (put that issue # in the comments).
Projects
None yet
Development

No branches or pull requests

3 participants