From 6395af320d4ff622d321a8673776a146fef66ac8 Mon Sep 17 00:00:00 2001 From: Itami Sho <42286868+MiniSho@users.noreply.github.com> Date: Fri, 21 Jun 2024 20:33:34 +0800 Subject: [PATCH] Load: change the metric type of LoadDiskIO metric from RATE to COUNTER (#12787) --- .../metric/load/LoadTsFileCostMetricsSet.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/load/LoadTsFileCostMetricsSet.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/load/LoadTsFileCostMetricsSet.java index b0ce2ca69a45..d9ce0233b558 100644 --- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/load/LoadTsFileCostMetricsSet.java +++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/load/LoadTsFileCostMetricsSet.java @@ -25,7 +25,7 @@ import org.apache.iotdb.metrics.AbstractMetricService; import org.apache.iotdb.metrics.impl.DoNothingMetricManager; import org.apache.iotdb.metrics.metricsets.IMetricSet; -import org.apache.iotdb.metrics.type.Rate; +import org.apache.iotdb.metrics.type.Counter; import org.apache.iotdb.metrics.type.Timer; import org.apache.iotdb.metrics.utils.MetricLevel; import org.apache.iotdb.metrics.utils.MetricType; @@ -50,7 +50,7 @@ private LoadTsFileCostMetricsSet() { private Timer secondPhaseTimer = DoNothingMetricManager.DO_NOTHING_TIMER; private Timer loadLocallyTimer = DoNothingMetricManager.DO_NOTHING_TIMER; - private Rate diskIORate = DoNothingMetricManager.DO_NOTHING_RATE; + private Counter diskIOCounter = DoNothingMetricManager.DO_NOTHING_COUNTER; public void recordPhaseTimeCost(String stage, long costTimeInNanos) { switch (stage) { @@ -72,7 +72,7 @@ public void recordPhaseTimeCost(String stage, long costTimeInNanos) { } public void recordDiskIO(long bytes) { - diskIORate.mark(bytes); + diskIOCounter.inc(bytes); } @Override @@ -99,8 +99,8 @@ public void bindTo(AbstractMetricService metricService) { Tag.NAME.toString(), LOAD_LOCALLY); - diskIORate = - metricService.getOrCreateRate( + diskIOCounter = + metricService.getOrCreateCounter( Metric.LOAD_DISK_IO.toString(), MetricLevel.IMPORTANT, Tag.NAME.toString(),