Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent IDs for FMN and FMNH2 #711

Open
5 tasks done
Devlin-Moyer opened this issue Oct 20, 2023 · 4 comments
Open
5 tasks done

Inconsistent IDs for FMN and FMNH2 #711

Devlin-Moyer opened this issue Oct 20, 2023 · 4 comments
Labels

Comments

@Devlin-Moyer
Copy link
Collaborator

Devlin-Moyer commented Oct 20, 2023

Current behavior:

I was starting to work on implementing the changes I proposed in #609, and I noticed inconsistencies in the metabolite IDs for FMN and FMNH2 metabolites in different compartments:

ID Name Compartment Formula Charge
MAM01828c FMN c C17H19N4O9P -2
MAM01828x FMN x C17H19N4O9P -2
MAM01828e FMN e C17H19N4O9P -2
MAM20020r FMN r C17H18N4O9P -2
MAM20023i FMN i C17H18N4O9P -2
MAM20019r FMNH2 r C17H21N4O9P -2
MAM20022i FMNH2 i C17H21N4O9P -2

(These are all of the metabolites currently in Human-GEM that have "FMN" in their names. Also I bolded the number of hydrogens in the empricial formulas just to make it clear that that's the only part that changes)

Expected feature/value/output:

  • All of the FMN metabolites should have the same IDs except for the compartment suffix, so MAM20020r should be MAM01828r and MAM20023i should be MAM01828i.
  • Same for the FMNH2 metabolites: MAM20022i should be MAM20019i.
  • The empirical formulas for all FMN metabolites should be the same. According to ChEBI, PubChem, and KEGG, the formula for (neutral) FMN should be C17H21N4O9P, and since these represent the -2 ion of FMN, the formulas for MAM20020r and MAM20023i should be changed to C17H19N4O9P.
  • All of the FMN metabolites should be associated with the same KEGG ID, so MAM20020r and MAM20023i should both be associated with C00061.
  • Relatedly, neither of the FMNH2 metabolites are currently associated with a KEGG ID, so they can both be associated with C01847.
@haowang-bioinfo
Copy link
Member

thanks for the scrutiny, go ahead to implementation please

@Devlin-Moyer
Copy link
Collaborator Author

FYI I just edited my proposed changes a bit because I realized the empirical formulas I looked up were for neutral FMN and FMNH2, but these metabolites represent their -2 ions since their phosphate groups deprotonate in water at physiological pHs.

@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented Oct 20, 2023

yes, KEGG often picks neutral state for metabolites - in fact the protonation state under pH 7.3 is favoured

@Devlin-Moyer Devlin-Moyer mentioned this issue Oct 20, 2023
3 tasks
@haowang-bioinfo
Copy link
Member

let's keep this issue open until the charge-balancing fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants