Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sirf.Reg only wraps non symetrical version of f3d #684

Open
AnderBiguri opened this issue May 28, 2020 · 2 comments
Open

sirf.Reg only wraps non symetrical version of f3d #684

AnderBiguri opened this issue May 28, 2020 · 2 comments

Comments

@AnderBiguri
Copy link
Contributor

This is due to a bug in NiftyReg. Would need them to fix it to wrap both.

More info in #680

@AnderBiguri
Copy link
Contributor Author

@rijobro btw, the algorithm is still called sirf.Reg.NiftyF3dSym. Should that maybe be different now?

@rijobro
Copy link
Contributor

rijobro commented Jun 2, 2020

I'd rather keep it that way so that:

  1. it doesn't break backwards compatibility; and
  2. once the bug is fixed, it can be symmetric with the option to not be symmetric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants