Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Escape GitHub Emoji Shortcodes #23

Closed
mattt opened this issue Mar 28, 2020 · 1 comment
Closed

Escape GitHub Emoji Shortcodes #23

mattt opened this issue Mar 28, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
1.0.0-beta.2

Comments

@mattt
Copy link
Contributor

mattt commented Mar 28, 2020

GitHub renders shortcodes like :heart_eyes :.

This causes issues for code symbols like this initializer:

  • Unescaped: init(imports:symbols:)
  • Escaped in code: init(imports:symbols:)
@mattt mattt added this to the 1.0.0 milestone Apr 1, 2020
@mattt mattt added the bug Something isn't working label Apr 1, 2020
@mattt
Copy link
Contributor Author

mattt commented Apr 6, 2020

This is fixed by #55, as can be seen here.

Screen Shot 2020-04-06 at 08 24 08

@mattt mattt closed this as completed Apr 6, 2020
@mattt mattt mentioned this issue Sep 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-beta.2
Development

No branches or pull requests
1 participant
@mattt