Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call load_plugin_textdomain() #254

Open
iandunn opened this issue Nov 23, 2015 · 4 comments
Open

Call load_plugin_textdomain() #254

iandunn opened this issue Nov 23, 2015 · 4 comments
Labels
bug good first bug Priority: High

Comments

@iandunn
Copy link
Contributor

iandunn commented Nov 23, 2015

https://wordpress.slack.com/archives/meta-language-packs/p1448049108001972
@iandunn
Copy link
Contributor Author

iandunn commented Aug 17, 2016

4.6 prioritizes translate.w.org packages over bundled ones, so this may no longer be necessary. I'm not sure about that, though.

@Kenshino
Copy link

Don't other translation plugins depend on load_plugin_textdomain() ?

@iandunn
Copy link
Contributor Author

iandunn commented Aug 22, 2016

Oh, you mean like WPML? I hadn't thought about that use case, that's a good point.

@Kenshino
Copy link

Aye. The theme review team discussed this as well. Core can handle the priority, but the load_plugin_textdomain should remain for compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first bug Priority: High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iandunn @Kenshino