Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python 3 version support #49

Closed
markcampanelli opened this issue May 17, 2019 · 2 comments
Closed

Update Python 3 version support #49

markcampanelli opened this issue May 17, 2019 · 2 comments

Comments

@markcampanelli
Copy link

https://github.com/pvlib/pvlib-python/tree/v0.6.3 lists Python 3.4-7 support (see https://github.com/pvlib/pvlib-python/blob/v0.6.3/setup.py). pvfactors is listed as optional, but is called out in the CI requirements for the Python 3.5-7 runs, but Python 3.4 is not included (e.g., https://github.com/pvlib/pvlib-python/blob/v0.6.3/ci/requirements-py34.yml vs. https://github.com/pvlib/pvlib-python/blob/v0.6.3/ci/requirements-py37.yml).

pvfactors should be more clear about which Python 3 versions are supported in the CLASSIFIERS variable in https://github.com/SunPower/pvfactors/blob/master/setup.py (e.g., more than just 'Programming Language :: Python :: 3.6'). It would also be worth checking that the dependency ranges in https://github.com/SunPower/pvfactors/blob/master/requirements.txt are indeed compatible with those Python 3 versions. (It might be nice to be more specific about Python 2 versions as well.)

@markcampanelli
Copy link
Author

@anomam Do you know what the lower bound on pandas should now be?

https://github.com/SunPower/pvfactors/blob/master/requirements.txt#L3

@anomam
Copy link
Contributor

anomam commented May 20, 2019

Thanks for this @markcampanelli , I think that the lower bound should be the same as in pvlib, because the only functions in pvfactors that really depend on pandas are in the irradiance models, which use pvlib. I'm thinking of just removing the lower bound on that line (and maybe a few other lines as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants