Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wdi_property_store.wd_properties with calls to the constraint check api #71

Closed
stuppie opened this issue Jun 17, 2018 · 2 comments

Comments

@stuppie
Copy link
Collaborator

stuppie commented Jun 17, 2018

The defaults in wdi_property_store.wd_properties are not very generic and cause issues with running a local wikibase (it must be cleared).
Consider removing this and using the Constraint system instead.

@stuppie
Copy link
Collaborator Author

stuppie commented Jun 25, 2018

Proposal:

On wikidata, the default core IDs will be the properties with a distinct values constraint
(select ?p where {?p wdt:P2302 wd:Q21502410} (run))

On a wikibase, we need some way of getting the property constraint qid and pids, so this will be empty by default. There was talk at the workshop of making a standard "config" file for a wikibase instance that would list things like these IDs. WDI could use this config file to retrieve these, as well as other things it may need like mapping relation type QIDs
See: https://phabricator.wikimedia.org/T197588

@stuppie
Copy link
Collaborator Author

stuppie commented Jul 24, 2018

Done here: 1c298a7
Will merge once I fix some bots...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant