From d6403685a486877ca4bfeefa7c3e053495ee8bba Mon Sep 17 00:00:00 2001 From: Pragadeeswaran Sathyanarayanan Date: Thu, 2 Jan 2025 18:00:31 +0530 Subject: [PATCH] Fix codeowners file Earlier cephci-top-reviewers had open permissions to merge code to any place. The teams mentioned for folders had no impact. This caused improper delegation of ownership. This change removes the top-reviewers group and sets the complete privileges to ceph-qe-ci and ceph-qe-admin groups. They have full access to merge. The delegation to each DFG is now done via specfic users with their managers having permissions to merge in their respective components. Going forward, anyone should be able to raise a PR to request for merge permissions with admin and ci teams having approval privileges. Signed-off-by: Pragadeeswaran Sathyanarayanan --- .github/CODEOWNERS | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 2c6118ea46b..ae6d4fe5749 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,24 +1,29 @@ # These owners will be the default owners for everything in this repo. # all changes. -* @red-hat-storage/cephci-top-reviewers +* @red-hat-storage/ceph-qe-ci @red-hat-storage/ceph-qe-admin # for RGW -rgw/ @red-hat-storage/teams/cephci-rgw +rgw/ @mkasturi18 @ckulal @TejasC88 # for RBD team -rbd/ @red-hat-storage/teams/cephci-block -rbd_mirror/ @red-hat-storage/teams/cephci-block +rbd/ @Manohar-Murthy +rbd_mirror/ @Manohar-Murthy + +# for NVMe-oF +nvmeof/ @Manohar-Murthy @HaruChebrolu # for RADOS -rados/ @ed-hat-storage/teams/cephci-rados +rados/ @neha-gangadhar @pdhiran # for FS -cephfs/ @red-hat-storage/teams/cephci-fs +cephfs/ @neha-gangadhar @AmarnatReddy @Manimaran-MM + +# smb +smb/ @vdas-redhat @pranavprakash20 # for DMFG -ansible/ @red-hat-storage/teams/cephci-dm -upgrades/ @red-hat-storage/teams/cephci-dm -dashboard/ @red-hat-storage/teams/cephci-dm -cephadm/ @red-hat-storage/teams/cephci-dm -ceph_ansisble/ @red-hat-storage/teams/cephci-dm -ceph_installer/ @red-hat-storage/teams/cephci-dm +ceph_volume/ @vdas-redhat @pranavprakash20 +cephadm/ @vdas-redhat @pranavprakash20 +mgr/ @vdas-redhat @pranavprakash20 +nfs/ @vdas-redhat @pranavprakash20 +upgrades/ @vdas-redhat @pranavprakash20