Skip to content

Commit

Permalink
Add CodeClimate documentation (publiclab#3068)
Browse files Browse the repository at this point in the history
* CodeClimate documentation

* Changing image: doc/images/code_climate.png
  • Loading branch information
Stefanni authored and jywarren committed Jul 17, 2018
1 parent b8f6bd1 commit acb4311
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions CODECLIMATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Code Climate

We are implementing a [Code Climate](https://docs.codeclimate.com/docs) automation test to improve the quality of our code.

# Issues

CodeClimate is picky -- any time you think it's being too particular, you can ping @publiclab/reviewers and they can manually "approve" a PR and you can move forward -- not a problem! But if you click "details" next to CodeClimate, it'll offer some advice:

![Issues from a Pull Request](doc/images/code_climate.png)

The most common is to refactor your code to avoid duplication or methods with
too many lines.

Below you can see CodeClimate complaining about "cognitive complexity" -- basically,
asking you to try to simplify how the code is written in order to make it more readable:

![Cognitive Complexity example](doc/images/cognitive_complexity_example.png)

If you hover over the right-side of each issue, it has a "read more" link which offers some tips on how to resolve it:

![Cognitive Complexity example](doc/images/codeclimate_read_up.png)

CodeClimate is picky so if you have more questions or need help, you can always
ask for help.
Binary file added doc/images/code_climate.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added doc/images/code_climate_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added doc/images/codeclimate_read_up.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added doc/images/cognitive_complexity_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit acb4311

Please sign in to comment.