Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] No desktop notification #278

Closed
takattowo opened this issue Dec 12, 2024 · 10 comments
Closed

[Bug] No desktop notification #278

takattowo opened this issue Dec 12, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@takattowo
Copy link

takattowo commented Dec 12, 2024

Describe the bug
There is no discord notification, only sound (already enabled notification, when clicking button it also only played sound instead of showing a demo notification).

To Reproduce
Get notified.

System Info (please complete the following information):

  • OS: Windows 11
  • Version: 6.3.0
  • Extra Client Mods/Plugins: Vanilla (no install anything)
  • Any other relevant info: I use portable version.
@takattowo takattowo added the bug Something isn't working label Dec 12, 2024
@SpikeHD
Copy link
Owner

SpikeHD commented Dec 12, 2024

Can you screenshot what is logged in devtools (Ctrl + Shift + i, then click "Console") when you disable and re-enable desktop notifications? Does anything change if you restart Dorion?

@takattowo
Copy link
Author

takattowo commented Dec 12, 2024

Can you screenshot what is logged in devtools (Ctrl + Shift + i, then click "Console") when you disable and re-enable desktop notifications? Does anything change if you restart Dorion?

Here: https://streamable.com/dq7olr

I also restarted the client but didnt work.

@v3xro
Copy link

v3xro commented Dec 19, 2024

On MacOS 15.2.0 with 6.3.0 it's the same - the error in the console is:

[Error] Unhandled Promise Rejection: Command plugin:notification|request_permission not allowed by ACL
	(anonymous function) (user-script:8:1:587)

Which seems to be related to tauri-apps/tauri#9502

@SpikeHD
Copy link
Owner

SpikeHD commented Dec 19, 2024

It's not related to that issue, in fact I think you're having a slightly different problem than the one here, but the log was helpful for fixing it, thanks!

@Jovian-Dsouza
Copy link

facing the same issue, any fix on this

@SpikeHD
Copy link
Owner

SpikeHD commented Dec 21, 2024

@Jovian-Dsouza It is being investigated. Are you also on Windows 11 like the original reporter and on a portable install?

@SpikeHD
Copy link
Owner

SpikeHD commented Dec 21, 2024

@takattowo @Jovian-Dsouza many things have changed regarding notifications since v6.3.0, can you please try a bleeding-edge build?

Just download whatever latest build has succeeded for your platform here, or alternatively, you can find them in the Downloads section of the README, under "View bleeding-edge builds" dropdown.

@Jovian-Dsouza
Copy link

Hi @SpikeHD, fixed the issue, thanks

@SpikeHD
Copy link
Owner

SpikeHD commented Jan 2, 2025

Notifications have changed a lot since v6.3.0 release, I'm gonna close this since I believe most notification-related issues are now solved. You can check yourself by following the instructions from my comment above in order to install a bleeding-edge build, or wait until the next release.

@SpikeHD SpikeHD closed this as completed Jan 2, 2025
@Tayruu
Copy link

Tayruu commented Feb 1, 2025

I'm not having notifications show up either on 6.4.1, W11 portable install. (Also tried the workflow build 970.) The only thing I can see when toggling notifications in the console is API rejections.

Image

I think they work if I enable W7-style notifications, but the problem with these is they double up the alert (both Windows alert and Discord alert play) and do not scale to my high-dpi screen. Screenshot below to show the scale difference between the fonts.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants