Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaConnectClient not supporting stop operation #86

Closed
elene opened this issue Jul 5, 2024 · 5 comments · Fixed by #89
Closed

KafkaConnectClient not supporting stop operation #86

elene opened this issue Jul 5, 2024 · 5 comments · Fixed by #89

Comments

@elene
Copy link

elene commented Jul 5, 2024

Hi,

KafkaConnectClient doesn't implement stop endpoint from KafkaConnect API. Is it intentional or it just was not implemented?

It should be straightforward to implement:

  • Create a new PutConnectorStop class (similar to this) class and update the endpoint to use stop instead of pause
  • Add a new stopConnector (similar to this) and use PutConnectorStop class to create a request.
  • Add tests
@Crim
Copy link
Collaborator

Crim commented Jul 5, 2024

I believe it was just not implemented. I'd be happy to accept a PR for implementing it, and cut a new release including it. :)

@anleib
Copy link

anleib commented Oct 4, 2024

The stop operation was recently added in here
It would be pretty easy to add it here; I'll try to find some time to work on a PR.
Unless you would like to do the PR @elene

@m8719-github
Copy link
Contributor

PR ready for review

@Crim
Copy link
Collaborator

Crim commented Oct 6, 2024

Thanks for the PR! I'll try to cut a release here shortly.

@Crim
Copy link
Collaborator

Crim commented Oct 6, 2024

published 4.0.5 to maven central and cut a release here in github.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants